From: <gregkh@linuxfoundation.org>
To: tiwai@suse.de, andreyknvl@google.com, gregkh@linuxfoundation.org
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "ALSA: line6: Fix NULL dereference at podhd_disconnect()" has been added to the 4.13-stable tree
Date: Sun, 15 Oct 2017 16:06:40 +0200 [thread overview]
Message-ID: <1508076400335@kroah.com> (raw)
This is a note to let you know that I've just added the patch titled
ALSA: line6: Fix NULL dereference at podhd_disconnect()
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-line6-fix-null-dereference-at-podhd_disconnect.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 54a4b2b45817ea2365b40c923c098a26af0c0dbb Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 9 Oct 2017 14:26:27 +0200
Subject: ALSA: line6: Fix NULL dereference at podhd_disconnect()
From: Takashi Iwai <tiwai@suse.de>
commit 54a4b2b45817ea2365b40c923c098a26af0c0dbb upstream.
When podhd_init() failed with the acquiring a ctrl i/f, the line6
helper still calls the disconnect callback that eventually calls again
usb_driver_release_interface() with the NULL intf.
Put the proper NULL check before calling it for avoiding an Oops.
Fixes: fc90172ba283 ("ALSA: line6: Claim pod x3 usb data interface")
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
sound/usb/line6/podhd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/sound/usb/line6/podhd.c
+++ b/sound/usb/line6/podhd.c
@@ -301,7 +301,8 @@ static void podhd_disconnect(struct usb_
intf = usb_ifnum_to_if(line6->usbdev,
pod->line6.properties->ctrl_if);
- usb_driver_release_interface(&podhd_driver, intf);
+ if (intf)
+ usb_driver_release_interface(&podhd_driver, intf);
}
}
Patches currently in stable-queue which might be from tiwai@suse.de are
queue-4.13/alsa-line6-fix-null-dereference-at-podhd_disconnect.patch
queue-4.13/alsa-line6-fix-missing-initialization-before-error-path.patch
queue-4.13/alsa-caiaq-fix-stray-urb-at-probe-error-path.patch
queue-4.13/alsa-seq-fix-copy_from_user-call-inside-lock.patch
queue-4.13/alsa-seq-fix-use-after-free-at-creating-a-port.patch
queue-4.13/alsa-line6-fix-leftover-urb-at-error-path-during-probe.patch
queue-4.13/alsa-usb-audio-kill-stray-urb-at-exiting.patch
reply other threads:[~2017-10-15 14:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508076400335@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreyknvl@google.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).