From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
akpm@linux-foundation.org, bp@alien8.de,
dave.hansen@linux.intel.com, dvyukov@google.com,
ebiggers@google.com, fenghua.yu@intel.com, haokexin@gmail.com,
keescook@chromium.org, luto@amacapital.net, luto@kernel.org,
mhalcrow@google.com, mingo@kernel.org, oleg@redhat.com,
peterz@infradead.org, riel@redhat.com, tglx@linutronix.de,
torvalds@linux-foundation.org, wanpeng.li@hotmail.com,
yu-cheng.yu@intel.com
Subject: Re: Patch "x86/fpu: Don't let userspace set bogus xcomp_bv" has been added to the 4.4-stable tree
Date: Mon, 16 Oct 2017 18:55:06 +0100 [thread overview]
Message-ID: <1508176506.22379.31.camel@codethink.co.uk> (raw)
In-Reply-To: <20171016175202.GB121701@gmail.com>
On Mon, 2017-10-16 at 10:52 -0700, Eric Biggers wrote:
> Hi Ben,
>
> On Mon, Oct 16, 2017 at 06:34:52PM +0100, Ben Hutchings wrote:
> > > > On Mon, 2017-10-02 at 20:59 +0200, gregkh@linuxfoundation.org wrote:
> > [...]
> > > > > > From: Eric Biggers <ebiggers@google.com>
> > >
> > > commit 814fb7bb7db5433757d76f4c4502c96fc53b0b5e upstream.
> > >
> > > [Please apply to 4.4-stable. Note: the backport includes the
> > > fpstate_init() call in xstateregs_set(), since fix is useless without
> > > it. It was added by commit 91c3dba7dbc1 ("x86/fpu/xstate: Fix PTRACE
> > > frames for XSAVES"), but it doesn't make sense to backport that whole
> > > commit.]
> >
> > [...]
> >
> > Why doesn't it make sense to backport that? It seems less important
> > than this fix, but it fixes a userspace-visible regression.
> >
>
> It seems that commit was part of a series of commits that fixed XSAVES support
> and then re-enabled it. Before then the XSAVES support was actually disabled;
> see commit e88221c50cad ("x86/fpu: Disable XSAVES* support for now"). So commit
> 91c3dba7dbc1 didn't fix a regression, as the code was already disabled.
I missed that. Thanks.
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
prev parent reply other threads:[~2017-10-16 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 18:04 [PATCH] x86/fpu: Don't let userspace set bogus xcomp_bv Eric Biggers
2017-10-02 18:59 ` Patch "x86/fpu: Don't let userspace set bogus xcomp_bv" has been added to the 4.4-stable tree gregkh
2017-10-16 17:34 ` Ben Hutchings
2017-10-16 17:52 ` Eric Biggers
2017-10-16 17:55 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508176506.22379.31.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=haokexin@gmail.com \
--cc=keescook@chromium.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mhalcrow@google.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wanpeng.li@hotmail.com \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).