stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "ceph: fix bogus endianness change in ceph_ioctl_set_layout" has been added to the 4.9-stable tree
@ 2017-10-19 13:14 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-10-19 13:14 UTC (permalink / raw)
  To: jlayton, alexander.levin, gregkh, idryomov, sage; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ceph: fix bogus endianness change in ceph_ioctl_set_layout

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ceph-fix-bogus-endianness-change-in-ceph_ioctl_set_layout.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Thu Oct 19 15:04:02 CEST 2017
From: Jeff Layton <jlayton@redhat.com>
Date: Thu, 12 Jan 2017 14:42:40 -0500
Subject: ceph: fix bogus endianness change in ceph_ioctl_set_layout

From: Jeff Layton <jlayton@redhat.com>


[ Upstream commit 24c149ad6914d349d8b64749f20f3f8ea5031fe0 ]

sparse says:

    fs/ceph/ioctl.c:100:28: warning: cast to restricted __le64

preferred_osd is a __s64 so we don't need to do any conversion. Also,
just remove the cast in ceph_ioctl_get_layout as it's not needed.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 fs/ceph/ioctl.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/fs/ceph/ioctl.c
+++ b/fs/ceph/ioctl.c
@@ -25,7 +25,7 @@ static long ceph_ioctl_get_layout(struct
 		l.stripe_count = ci->i_layout.stripe_count;
 		l.object_size = ci->i_layout.object_size;
 		l.data_pool = ci->i_layout.pool_id;
-		l.preferred_osd = (s32)-1;
+		l.preferred_osd = -1;
 		if (copy_to_user(arg, &l, sizeof(l)))
 			return -EFAULT;
 	}
@@ -97,7 +97,7 @@ static long ceph_ioctl_set_layout(struct
 		nl.data_pool = ci->i_layout.pool_id;
 
 	/* this is obsolete, and always -1 */
-	nl.preferred_osd = le64_to_cpu(-1);
+	nl.preferred_osd = -1;
 
 	err = __validate_layout(mdsc, &nl);
 	if (err)


Patches currently in stable-queue which might be from jlayton@redhat.com are

queue-4.9/ceph-fix-bogus-endianness-change-in-ceph_ioctl_set_layout.patch
queue-4.9/ceph-clean-up-unsafe-d_parent-accesses-in-build_dentry_path.patch
queue-4.9/ceph-don-t-update_dentry_lease-unless-we-actually-got-one.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-10-19 13:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-19 13:14 Patch "ceph: fix bogus endianness change in ceph_ioctl_set_layout" has been added to the 4.9-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).