* Patch "drm/fsl-dcu: check for clk_prepare_enable() error" has been added to the 4.9-stable tree
@ 2017-11-06 9:11 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-11-06 9:11 UTC (permalink / raw)
To: fabio.estevam, alexander.levin, gregkh, stefan; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
drm/fsl-dcu: check for clk_prepare_enable() error
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-fsl-dcu-check-for-clk_prepare_enable-error.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From foo@baz Mon Nov 6 10:07:35 CET 2017
From: Fabio Estevam <fabio.estevam@nxp.com>
Date: Sat, 7 Oct 2017 22:36:51 +0000
Subject: drm/fsl-dcu: check for clk_prepare_enable() error
From: Fabio Estevam <fabio.estevam@nxp.com>
[ Upstream commit ef15d36154cc741d7ded4ae4fa0cf7987354e313 ]
clk_prepare_enable() may fail, so we should better check its return
value.
Also place the of_node_put() function right after clk_prepare_enable(),
in order to avoid calling of_node_put() twice in case clk_prepare_enable()
fails.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--- a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
@@ -89,9 +89,13 @@ struct fsl_tcon *fsl_tcon_init(struct de
goto err_node_put;
}
- of_node_put(np);
- clk_prepare_enable(tcon->ipg_clk);
+ ret = clk_prepare_enable(tcon->ipg_clk);
+ if (ret) {
+ dev_err(dev, "Couldn't enable the TCON clock\n");
+ goto err_node_put;
+ }
+ of_node_put(np);
dev_info(dev, "Using TCON in bypass mode\n");
return tcon;
Patches currently in stable-queue which might be from fabio.estevam@nxp.com are
queue-4.9/drm-fsl-dcu-check-for-clk_prepare_enable-error.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-11-06 9:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-06 9:11 Patch "drm/fsl-dcu: check for clk_prepare_enable() error" has been added to the 4.9-stable tree gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).