From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:49618 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754367AbdKFQzh (ORCPT ); Mon, 6 Nov 2017 11:55:37 -0500 Message-ID: <1509987320.2748.94.camel@decadent.org.uk> Subject: Re: [PATCH 3.16-stable 11/87] iio: fix printk format string warning From: Ben Hutchings To: Arnd Bergmann Cc: stable@vger.kernel.org Date: Mon, 06 Nov 2017 16:55:20 +0000 In-Reply-To: <20170505194745.3627137-12-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> <20170505194745.3627137-12-arnd@arndb.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-SSLmqLtHwRJZSnrozoD5" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-SSLmqLtHwRJZSnrozoD5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2017-05-05 at 21:46 +0200, Arnd Bergmann wrote: > On 3.16, we get this warning: >=20 > drivers/iio/industrialio-core.c: In function 'iio_format_value': > drivers/iio/industrialio-core.c:408:30: error: format '%u' expects argume= nt of type 'unsigned int', but argument 4 has type 'long int' [-Werror=3Dfo= rmat=3D] >=20 > Upstream commit 8f57e4d930d4 ("include/linux/kernel.h: change abs() macro > so it uses consistent return type") addressed this in a more verbose > way, but here we can simply add a type cast to shut up the warning. I'm skipping this one because I have now cherry-picked that commit. Ben. > Signed-off-by: Arnd Bergmann > --- > drivers/iio/industrialio-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-c= ore.c > index 230cbdda6ce1..669c27d93049 100644 > --- a/drivers/iio/industrialio-core.c > +++ b/drivers/iio/industrialio-core.c > @@ -405,7 +405,7 @@ ssize_t iio_format_value(char *buf, unsigned int type= , int size, int *vals) > case IIO_VAL_FRACTIONAL: > tmp =3D div_s64((s64)vals[0] * 1000000000LL, vals[1]); > vals[0] =3D (int)div_s64_rem(tmp, 1000000000, &vals[1]); > - return sprintf(buf, "%d.%09u\n", vals[0], abs(vals[1])); > + return sprintf(buf, "%d.%09ld\n", vals[0], abs(vals[1])); > case IIO_VAL_FRACTIONAL_LOG2: > tmp =3D (s64)vals[0] * 1000000000LL >> vals[1]; > vals[1] =3D do_div(tmp, 1000000000LL); --=20 Ben Hutchings It is a miracle that curiosity survives formal education. - Albert Einstein --=-SSLmqLtHwRJZSnrozoD5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAloAk/gACgkQ57/I7JWG EQm9Kg//ULaUNtqvmbC1qpyK+egRlUCxIMQDZPI95dGRc4gMckLuq1h15RW5OI8k LtJXSrRvTlbsYq7q1vHJD9YLy/Ir/R54s0Aeksu5xrl2Me8Fc8fKvIAHbQaQYfYL ncO9wHKUXGaMLe4E5aIE0mD6D0Bq1Azhq5QEiQW6KgsTm35Xacc9jy4Gsph+aK73 kgxBtpBNC6pJLgTU7Ici9Ige+MpVrj4QR+psC57TM9u8lmry+ZqaXVs7xPcXrTy1 +mLy9glXXjd7/Kw7leF++jcSHtxkM+PsUcZnIivXVDYPMQMIzvDTXNbwgg7mNdO3 UaeV6BQ2ibaDO1iXqmeybrbx9jPTNPG5JZQAGZ4etZYopb11niaOy52Utux7X9sR hp4IRQ7mFTEDNazRV/xybJ1nanFXTTpUdJ70vrJERSEazKhf35MJDKnZT8rFGdmU gYSS1NITrJwSZNBUxIpVDeZPZHJrMlOFBvGwYBJCMsLFmhkVesnwvN3SuInDSVGd bX0yeKUk/54dkZY6pIqNQ5vujahupm4mTMIpaS3XteZWcKLLYviV78rSag1Cgvuj 1DmjYotskT7ZY4UqtxUeDbEW5YN8JZzftM72IX3EhCcy6SZ72tN0yh0MSJvO+Xno Q+1LggTWjLwEKWNzLVs/kjkbSVivwJI/5WmqlwY8jgeRrZ23c2s= =ludY -----END PGP SIGNATURE----- --=-SSLmqLtHwRJZSnrozoD5--