From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:49830 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753430AbdKFRb6 (ORCPT ); Mon, 6 Nov 2017 12:31:58 -0500 Message-ID: <1509989499.2748.101.camel@decadent.org.uk> Subject: Re: [PATCH 3.16-stable 34/87] ips: remove pointless #warning From: Ben Hutchings To: Arnd Bergmann Cc: stable@vger.kernel.org, James Bottomley Date: Mon, 06 Nov 2017 17:31:39 +0000 In-Reply-To: <20170505194745.3627137-35-arnd@arndb.de> References: <20170505194745.3627137-1-arnd@arndb.de> <20170505194745.3627137-35-arnd@arndb.de> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ZOlwwElcGGGbMuhf1rBg" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-ZOlwwElcGGGbMuhf1rBg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2017-05-05 at 21:46 +0200, Arnd Bergmann wrote: > From: James Bottomley >=20 > Commit e03c2da6574223081b786960e39c1e5ecf5d492d upstream. >=20 > non-x86 builds want the #warning in the IPS code about compiling on the w= rong > architecture removed because it keeps triggering on their platforms build > farms. Transform from a compile time warning into a runtime one with tai= nt to > preserve the original intent of the authors. I'll apply this, but: [...] > @@ -6789,6 +6785,11 @@ ips_remove_device(struct pci_dev *pci_dev) > static int __init > ips_module_init(void) > { > +#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__) > + printk(KERN_ERR "ips: This driver has only been tested on the x86/ia64/= x86_64 platforms\n"); > + add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK); > +#endif [...] This is not the right taint flag to use.=20 Documentation/sysctl/kernel.txt says: 4 - Unsafe SMP processors: SMP with CPUs not designed for SMP. Ben. --=20 Ben Hutchings It is a miracle that curiosity survives formal education. - Albert Einstein --=-ZOlwwElcGGGbMuhf1rBg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAloAnHwACgkQ57/I7JWG EQloLhAAkRvunMMB+kc6SnR9pfZlyssLv2coZH2qdFReeUJ++I/noCupGgXWTvlM rhzEswWc878F0wbPZjhOUjgBaxuwHOrx2ZYFmDzIjBVyqabo4FuDufPblbj+Zzzg nBNeHyc2ceijoyYHSnC+pDGdIjjBNnIrqRL/+/DZB8NAsnnAuSBjCZhRjOkrAF1C tDIJw3vORAas2VcJEX+7BeKURVJ7JDps984JcHYrh4rCl7/VmZBBM/1uWLhYBdkd 1BFLlw4zJnb1asNx7Rv9hdlgg4bAY7sR/jSVGGXuwzxnjJJf8xi6UpQTvSOg/tZa gTUsYpp35b1d84JpVIffWZtLgqyCcToKstUPkJZYjliWWZM0oyHYvz3VBT4m1zQh GrCVyftpiuW6HVGO4ASvbnzGFmsZQy1/ynCtBZnI1X0dsvsNu2KltQUkuszlOz4t EYVsaDbMHYGZ72noBo0a582HNT6jMr7reSWHyknfkdPFML9Qc9+ZiPEskhE2052o 1mqzHh4z9kEeDL8H3Snwy336wMvHbvDke8PEfb7fG2Y11F8lOx+YUL/WKB73+bi6 mH2mmhCsFmNDkhexZHS9/IsKwMJwJX11kivfzXr7iMQvt269dTca6SdnfRao/xYk 7GAC5SWMVYho+Izqm4nvLSUPE86QYujrgKE88EEA0bkO7Bka8wU= =LrLu -----END PGP SIGNATURE----- --=-ZOlwwElcGGGbMuhf1rBg--