public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jan Kara <jack@suse.cz>, Theodore Ts'o <tytso@mit.edu>
Cc: "HUANG Weller (CM/ESW12-CN)" <Weller.Huang@cn.bosch.com>,
	stable <stable@vger.kernel.org>
Subject: Re: Security fixes for 4.4
Date: Fri, 17 Nov 2017 12:06:50 +0000	[thread overview]
Message-ID: <1510920410.18523.98.camel@codethink.co.uk> (raw)
In-Reply-To: <20171116112956.GA23318@kroah.com>

On Thu, 2017-11-16 at 12:29 +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 15, 2017 at 09:10:46PM +0000, Ben Hutchings wrote:
> > Please apply the attached backported patches to 4.4-stable.  The
> > upstream commits are:
> > 
> > 06bd3c36a733 ext4: fix data exposure after a crash
> 
> This patch did not apply, and when I worked at it by hand to apply, it
> then broke the build with:
> 	fs/ext4/inode.c: In function ‘ext4_map_blocks’:
> fs/ext4/inode.c:669:17: error: ‘EXT4_GET_BLOCKS_ZERO’ undeclared (first use in this function); did you mean ‘EXT4_GET_BLOCKS_PRE_IO’?
>        !(flags & EXT4_GET_BLOCKS_ZERO) &&
>                  ^~~~~~~~~~~~~~~~~~~~

I attached a mailbox with backported versions of all of these.  The
inline list was just for reference.

> As Ted didn't provide this on the list of ext4 patches to backport to
> 4.4 in the past, I'm a bit hesitant to take this now.  Are you sure it
> is needed?

The Fixes field refers to a commit that went into 3.8, so if that's
correct then yes this is needed.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.

  parent reply	other threads:[~2017-11-17 12:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 21:10 Security fixes for 4.4 Ben Hutchings
2017-11-16 11:29 ` Greg Kroah-Hartman
2017-11-16 22:07   ` Theodore Ts'o
2017-11-17  8:10     ` Greg Kroah-Hartman
2017-11-17 13:30     ` Ben Hutchings
2017-11-20 14:02       ` Jan Kara
2017-11-17 12:06   ` Ben Hutchings [this message]
2017-11-17 12:25     ` Greg Kroah-Hartman
2017-11-16 11:31 ` Greg Kroah-Hartman
2017-11-16 11:32   ` Paolo Bonzini
2017-11-16 13:28     ` Greg Kroah-Hartman
2017-11-16 11:33 ` Greg Kroah-Hartman
2017-11-16 11:33 ` Greg Kroah-Hartman
2017-11-16 11:34 ` Greg Kroah-Hartman
2017-11-19 10:18 ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2018-12-13 18:51 Ben Hutchings
2018-12-13 18:52 ` Ben Hutchings
2018-12-13 19:13 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510920410.18523.98.camel@codethink.co.uk \
    --to=ben.hutchings@codethink.co.uk \
    --cc=Weller.Huang@cn.bosch.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox