From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap1.codethink.co.uk ([176.9.8.82]:55603 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbdKQMG5 (ORCPT ); Fri, 17 Nov 2017 07:06:57 -0500 Message-ID: <1510920410.18523.98.camel@codethink.co.uk> Subject: Re: Security fixes for 4.4 From: Ben Hutchings To: Greg Kroah-Hartman , Jan Kara , Theodore Ts'o Cc: "HUANG Weller (CM/ESW12-CN)" , stable Date: Fri, 17 Nov 2017 12:06:50 +0000 In-Reply-To: <20171116112956.GA23318@kroah.com> References: <1510780246.18523.74.camel@codethink.co.uk> <20171116112956.GA23318@kroah.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Thu, 2017-11-16 at 12:29 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 15, 2017 at 09:10:46PM +0000, Ben Hutchings wrote: > > Please apply the attached backported patches to 4.4-stable.  The > > upstream commits are: > > > > 06bd3c36a733 ext4: fix data exposure after a crash > > This patch did not apply, and when I worked at it by hand to apply, it > then broke the build with: > fs/ext4/inode.c: In function ‘ext4_map_blocks’: > fs/ext4/inode.c:669:17: error: ‘EXT4_GET_BLOCKS_ZERO’ undeclared (first use in this function); did you mean ‘EXT4_GET_BLOCKS_PRE_IO’? >        !(flags & EXT4_GET_BLOCKS_ZERO) && >                  ^~~~~~~~~~~~~~~~~~~~ I attached a mailbox with backported versions of all of these. The inline list was just for reference. > As Ted didn't provide this on the list of ext4 patches to backport to > 4.4 in the past, I'm a bit hesitant to take this now.  Are you sure it > is needed? The Fixes field refers to a commit that went into 3.8, so if that's correct then yes this is needed. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.