From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from imap1.codethink.co.uk ([176.9.8.82]:60384 "EHLO
        imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751324AbdKUTHV (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 21 Nov 2017 14:07:21 -0500
Message-ID: <1511291234.18523.116.camel@codethink.co.uk>
Subject: Re: [PATCH 4.14 00/31] 4.14.1-stable review
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        shuahkh@osg.samsung.com, patches@kernelci.org,
        stable@vger.kernel.org
Date: Tue, 21 Nov 2017 19:07:14 +0000
In-Reply-To: <20171121170914.GA21561@kroah.com>
References: <20171119145951.136379453@linuxfoundation.org>
         <7bc1795a-a2f0-6837-19f0-93b21fca35ad@roeck-us.net>
         <1511277970.18523.113.camel@codethink.co.uk>
         <20171121163534.GA20401@kroah.com>
         <1511282778.18523.114.camel@codethink.co.uk>
         <20171121170914.GA21561@kroah.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, 2017-11-21 at 18:09 +0100, Greg Kroah-Hartman wrote:
> On Tue, Nov 21, 2017 at 04:46:18PM +0000, Ben Hutchings wrote:
> > On Tue, 2017-11-21 at 17:35 +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Nov 21, 2017 at 03:26:10PM +0000, Ben Hutchings wrote:
> > 
> > [...]
> > > > Not all 32-bit configurations can provide cmpxchg64().  i40e's use of
> > > > cmpxchg64() appears to be fixed by:
> > > > 
> > > > b74f571f59a8 i40e/i40evf: organize and re-number feature flags
> > > > b48be9978e4b i40e: fix flags declaration
> > > 
> > > So without those patches, are any specific arches/configs broken for
> > > 4.14?
> > 
> > 32-bit parisc is.
> 
> Ok, but that's a horrid hack on the i40e driver, it just happens to move
> the bitfield to a 32bit variable.  Can't we just provide a "real"
> cmpxchg64() for 32-bit parisc?

No.  There is a generic implementation of cmpxchg64() but it is only
suitable for non-SMP configurations.

> Or mark this driver as not buildable on that platform?

I suggested adding a 'depends 64BIT' but got no response.

Ben.

> I doubt anyone is doing 40gb networking on parisc :)
> 
> thanks,
> 
> greg k-h
> 
-- 
Ben Hutchings
Software Developer, Codethink Ltd.