From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:47244 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179AbdKWPKp (ORCPT ); Thu, 23 Nov 2017 10:10:45 -0500 Message-ID: <1511449588.27393.0.camel@suse.com> Subject: Re: [PATCH] USB: usbfs: Filter flags passed in from user space From: Oliver Neukum To: Greg KH Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, stable@vger.kernel.org Date: Thu, 23 Nov 2017 16:06:28 +0100 In-Reply-To: <20171123145721.GA18622@kroah.com> References: <20171123142834.29602-1-oneukum@suse.com> <20171123145721.GA18622@kroah.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Am Donnerstag, den 23.11.2017, 15:57 +0100 schrieb Greg KH: > On Thu, Nov 23, 2017 at 03:28:34PM +0100, Oliver Neukum wrote: > > > > USBDEVFS_URB_ISO_ASAP must be accepted only for ISO endpoints. > > Improve sanity checking. > > > > Signed-off-by: Oliver Neukum > > --- > > drivers/usb/core/devio.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > Didn't we do something like this already? I sent a patch. Alan found it insufficient. > Or was it something else? Was this triggered by some testing? Alexey's syzkaller tests showed that you can trigger it. Regards Oliver