From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "hch@lst.de" <hch@lst.de>
Cc: "jthumshirn@suse.de" <jthumshirn@suse.de>,
"stuart.w.hayes@gmail.com" <stuart.w.hayes@gmail.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"khorenko@virtuozzo.com" <khorenko@virtuozzo.com>
Subject: Re: [PATCH] Ensure that the SCSI error handler gets woken up
Date: Mon, 27 Nov 2017 21:39:07 +0000 [thread overview]
Message-ID: <1511818746.2993.14.camel@wdc.com> (raw)
In-Reply-To: <20171123081802.GA20705@lst.de>
On Thu, 2017-11-23 at 09:18 +0100, Christoph Hellwig wrote:
> > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> > index 5e89049e9b4e..f7f014c755d7 100644
> > --- a/drivers/scsi/scsi_error.c
> > +++ b/drivers/scsi/scsi_error.c
> > @@ -61,9 +61,10 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd);
> > static int scsi_try_to_abort_cmd(struct scsi_host_template *,
> > struct scsi_cmnd *);
> >
> > -/* called with shost->host_lock held */
> > void scsi_eh_wakeup(struct Scsi_Host *shost)
> > {
> > + lockdep_assert_held(shost->host_lock);
> > +
> > if (atomic_read(&shost->host_busy) == shost->host_failed) {
> > trace_scsi_eh_wakeup(shost);
> > wake_up_process(shost->ehandler);
>
> Can you split this comment to assert change into a separate patch, please?
Hello Christoph.
Thanks for the review. I will make the requested change.
Bart.
next prev parent reply other threads:[~2017-11-27 21:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 1:05 [PATCH] Ensure that the SCSI error handler gets woken up Bart Van Assche
2017-11-23 8:18 ` Christoph Hellwig
2017-11-27 21:39 ` Bart Van Assche [this message]
2017-11-23 10:39 ` Johannes Thumshirn
2017-11-27 21:53 ` Stuart Hayes
2017-11-27 23:56 ` Bart Van Assche
2017-11-28 9:04 ` Pavel Tikhomirov
2017-11-28 15:33 ` Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2017-11-28 8:38 Pavel Tikhomirov
2017-11-28 8:54 Pavel Tikhomirov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511818746.2993.14.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=khorenko@virtuozzo.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).