From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:56864 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753683AbdK3An3 (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 29 Nov 2017 19:43:29 -0500
Message-ID: <1512002605.14820.9.camel@redhat.com>
Subject: Re: [patch 15/28] IB/core: disable memory registration of
 filesystem-dax vmas
From: Doug Ledford <dledford@redhat.com>
To: akpm@linux-foundation.org, torvalds@linux-foundation.org,
        mm-commits@vger.kernel.org, dan.j.williams@intel.com,
        hal.rosenstock@gmail.com, hch@lst.de, inki.dae@samsung.com,
        jack@suse.cz, jgg@mellanox.com, jmoyer@redhat.com,
        jy0922.shim@samsung.com, kyungmin.park@samsung.com,
        mchehab@kernel.org, mgorman@suse.de, ross.zwisler@linux.intel.com,
        sean.hefty@intel.com, stable@vger.kernel.org,
        sw0312.kim@samsung.com, vbabka@suse.cz
Date: Wed, 29 Nov 2017 19:43:25 -0500
In-Reply-To: <5a1f4c87.I+FrXwXbOL6a0zuv%akpm@linux-foundation.org>
References: <5a1f4c87.I+FrXwXbOL6a0zuv%akpm@linux-foundation.org>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-mM6/O9GUWSooLW3tYRxk"
Mime-Version: 1.0
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>


--=-mM6/O9GUWSooLW3tYRxk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2017-11-29 at 16:10 -0800, akpm@linux-foundation.org wrote:
> From: Dan Williams <dan.j.williams@intel.com>
> Subject: IB/core: disable memory registration of filesystem-dax vmas
>=20
> Until there is a solution to the dma-to-dax vs truncate problem it is not
> safe to allow RDMA to create long standing memory registrations against
> filesytem-dax vmas.
>=20
> Link: http://lkml.kernel.org/r/151068941011.7446.7766030590347262502.stgi=
t@dwillia2-desk3.amr.corp.intel.com
> Fixes: 3565fce3a659 ("mm, x86: get_user_pages() for dax mappings")
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> Reported-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jason Gunthorpe <jgg@mellanox.com>
> Cc: Sean Hefty <sean.hefty@intel.com>
> Cc: Doug Ledford <dledford@redhat.com>
> Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
> Cc: Jeff Moyer <jmoyer@redhat.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Inki Dae <inki.dae@samsung.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Acked-by: Doug Ledford <dledford@redhat.com>

> ---
>=20
>  drivers/infiniband/core/umem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff -puN drivers/infiniband/core/umem.c~ib-core-disable-memory-registrat=
ion-of-fileystem-dax-vmas drivers/infiniband/core/umem.c
> --- a/drivers/infiniband/core/umem.c~ib-core-disable-memory-registration-=
of-fileystem-dax-vmas
> +++ a/drivers/infiniband/core/umem.c
> @@ -191,7 +191,7 @@ struct ib_umem *ib_umem_get(struct ib_uc
>  	sg_list_start =3D umem->sg_head.sgl;
> =20
>  	while (npages) {
> -		ret =3D get_user_pages(cur_base,
> +		ret =3D get_user_pages_longterm(cur_base,
>  				     min_t(unsigned long, npages,
>  					   PAGE_SIZE / sizeof (struct page *)),
>  				     gup_flags, page_list, vma_list);
> _

--=20
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint =3D AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD
--=-mM6/O9GUWSooLW3tYRxk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEErmsb2hIrI7QmWxJ0uCajMw5XL90FAlofVC0ACgkQuCajMw5X
L93GJRAAnyVxb+MYCmTIX2VWWnVuojxeNUIFU4l+bTxlwevqhqw01No023BCAETQ
9XBP83PvhFfdpbvlS+7ABrMskW2gg6ONdCQ3fknU7jy8fYlvxzW3s8Ss4Mc6K/uQ
iQAhppzfdnHjDw5UYi6qk/+qwYyRuXZeClWl0WO2pgsS/TRe12LDMJklQOIO448z
jNDXECfApLBY/7AB1aWFQI247YykQh3rM27vwA4saZIXw9dxQfB20fN33JVEXgAq
2xB8e5qqL80r3BC7PopvVQ1JS3GtAquKCEMWoYYAH4+yT5iBjP3cvrvuUawd43az
91obyphr/P2dCHtT/Yp/OdT2BfxjEuvN2gRT87a1fAKZSYuq/MAT9JQAxmSXeTlk
vFnEuIM9PGZCwzCE8EG6SrSoLs9IkVDyKDUL+4zS56g6uIo2EifwXxG/vXouLo/c
5jVHNT4lRKciPYltXs1wrFxRGgKanE3Zs6sS5ZYg8aFtfXLH2JwFBv1Vxs0EiZD5
Au5hbva5aR3rYDL/NYNnuCBaCNjvtu5xyjNMxeB7JfMDUie5bn9jDRMwTCh2YVAz
c3X4JJ+AvblsZJwrk9n3/fS1nzHADV0oCNgucsuFJaFCv71rC9JCd0hIRo4IOTtE
zQhpxUiS3pZvqrNbNCSCItgyKcm6F3ib3gotlEsfh18FnGMvF3E=
=/fwP
-----END PGP SIGNATURE-----

--=-mM6/O9GUWSooLW3tYRxk--