From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Sasha Levin <alexander.levin@verizon.com>
Subject: Re: [PATCH 4.4 38/49] xen-netfront: Improve error handling during initialization
Date: Fri, 08 Dec 2017 05:10:49 +0000 [thread overview]
Message-ID: <1512709849.18523.245.camel@codethink.co.uk> (raw)
In-Reply-To: <20171207124709.059301507@linuxfoundation.org>
On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch. If anyone has any objections, please let me
> know.
>
> ------------------
>
> From: Ross Lagerwall <ross.lagerwall@citrix.com>
>
>
> [ Upstream commit e2e004acc7cbe3c531e752a270a74e95cde3ea48 ]
[...]
> @@ -1950,9 +1942,10 @@ abort_transaction_no_dev_fatal:
> xenbus_transaction_end(xbt, 1);
> destroy_ring:
> xennet_disconnect_backend(info);
> - kfree(info->queues);
> - info->queues = NULL;
> + xennet_destroy_queues(info);
> out:
> + unregister_netdev(info->netdev);
> + xennet_free_netdev(info->netdev);
> return err;
> }
This last bit of cleanup looks wrong. It was subsequently changed
upstream by:
86b5672b1adb xen-netfront: avoid crashing on resume after a failure in talk_to_netback()
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
next prev parent reply other threads:[~2017-12-08 5:10 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 13:06 [PATCH 4.4 00/49] 4.4.105-stable review Greg Kroah-Hartman
2017-12-07 13:06 ` [PATCH 4.4 01/49] bcache: only permit to recovery read error when cache device is clean Greg Kroah-Hartman
2017-12-07 13:06 ` [PATCH 4.4 02/49] bcache: recover data from backing when data " Greg Kroah-Hartman
2017-12-07 13:06 ` [PATCH 4.4 03/49] uas: Always apply US_FL_NO_ATA_1X quirk to Seagate devices Greg Kroah-Hartman
2017-12-07 13:06 ` [PATCH 4.4 04/49] usb: quirks: Add no-lpm quirk for KY-688 USB 3.1 Type-C Hub Greg Kroah-Hartman
2017-12-07 13:06 ` [PATCH 4.4 05/49] serial: 8250_pci: Add Amazon PCI serial device ID Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 06/49] s390/runtime instrumentation: simplify task exit handling Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 07/49] USB: serial: option: add Quectel BG96 id Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 08/49] ima: fix hash algorithm initialization Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 09/49] s390/pci: do not require AIS facility Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 10/49] selftests/x86/ldt_get: Add a few additional tests for limits Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 11/49] serial: 8250_fintek: Fix rs485 disablement on invalid ioctl() Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 12/49] spi: sh-msiof: Fix DMA transfer size check Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 13/49] usb: dwc2: Fix UDC state tracking Greg Kroah-Hartman
2017-12-08 3:37 ` Ben Hutchings
2017-12-09 17:12 ` Greg Kroah-Hartman
2017-12-12 0:27 ` alexander.levin
2017-12-07 13:07 ` [PATCH 4.4 14/49] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if were in host mode Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 15/49] usb: phy: tahvo: fix error handling in tahvo_usb_probe() Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 16/49] serial: 8250: Preserve DLD[7:4] for PORT_XR17V35X Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 17/49] x86/entry: Use SYSCALL_DEFINE() macros for sys_modify_ldt() Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 18/49] EDAC, sb_edac: Fix missing break in switch Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 19/49] sysrq : fix Show Regs call trace on ARM Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 20/49] usbip: tools: Install all headers needed for libusbip development Greg Kroah-Hartman
2017-12-08 3:56 ` Ben Hutchings
2017-12-09 6:16 ` alexander.levin
2017-12-09 7:41 ` Greg Kroah-Hartman
2017-12-12 0:13 ` alexander.levin
2017-12-12 7:22 ` Greg Kroah-Hartman
2017-12-09 17:06 ` Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 21/49] perf test attr: Fix ignored test case result Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 22/49] kprobes/x86: Disable preemption in ftrace-based jprobes Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 23/49] net: systemport: Utilize skb_put_padto() Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 24/49] net: systemport: Pad packet before inserting TSB Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 25/49] ARM: OMAP1: DMA: Correct the number of logical channels Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 26/49] vti6: fix device register to report IFLA_INFO_KIND Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 27/49] net/appletalk: Fix kernel memory disclosure Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 28/49] ravb: Remove Rx overflow log messages Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 29/49] nfs: Dont take a reference on fl->fl_file for LOCK operation Greg Kroah-Hartman
2017-12-08 4:18 ` Ben Hutchings
2017-12-09 17:01 ` Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 30/49] KVM: arm/arm64: Fix occasional warning from the timer work function Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 31/49] NFSv4: Fix client recovery when server reboots multiple times Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 32/49] drm/exynos/decon5433: set STANDALONE_UPDATE_F on output enablement Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 33/49] net: sctp: fix array overrun read on sctp_timer_tbl Greg Kroah-Hartman
2017-12-08 4:34 ` Ben Hutchings
2017-12-09 17:02 ` Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 34/49] tipc: fix cleanup at module unload Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 35/49] dmaengine: pl330: fix double lock Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 36/49] tcp: correct memory barrier usage in tcp_check_space() Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 37/49] mm: avoid returning VM_FAULT_RETRY from ->page_mkwrite handlers Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 38/49] xen-netfront: Improve error handling during initialization Greg Kroah-Hartman
2017-12-08 5:10 ` Ben Hutchings [this message]
2017-12-09 17:04 ` Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 39/49] net: fec: fix multicast filtering hardware setup Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 40/49] Revert "ocfs2: should wait dio before inode lock in ocfs2_setattr()" Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 41/49] usb: hub: Cycle HUB power when initialization fails Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 42/49] usb: xhci: fix panic in xhci_free_virt_devices_depth_first Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 43/49] usb: Add USB 3.1 Precision time measurement capability descriptor support Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 44/49] usb: ch9: Add size macro for SSP dev cap descriptor Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 45/49] USB: core: Add type-specific length check of BOS descriptors Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 46/49] USB: Increase usbfs transfer limit Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 47/49] USB: devio: Prevent integer overflow in proc_do_submiturb() Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 48/49] USB: usbfs: Filter flags passed in from user space Greg Kroah-Hartman
2017-12-07 13:07 ` [PATCH 4.4 49/49] usb: host: fix incorrect updating of offset Greg Kroah-Hartman
2017-12-07 15:23 ` [PATCH 4.4 00/49] 4.4.105-stable review Nathan Chancellor
2017-12-07 20:06 ` Greg Kroah-Hartman
2017-12-07 20:54 ` Guenter Roeck
2017-12-08 0:06 ` Shuah Khan
2017-12-08 5:36 ` Naresh Kamboju
[not found] ` <5a299569.3bb0df0a.2b900.5bf0@mx.google.com>
[not found] ` <7hr2s5kn0w.fsf@baylibre.com>
2017-12-09 17:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512709849.18523.245.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=alexander.levin@verizon.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.lagerwall@citrix.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).