From: Stephen Finucane <stephen@that.guru>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
patchwork@lists.ozlabs.org
Cc: tomas@novotny.cz, stable@vger.kernel.org
Subject: Re: [PATCH] views: Don't render token section of user profile if REST API disabled
Date: Thu, 04 Jan 2018 11:30:58 +0000 [thread overview]
Message-ID: <1515065458.32193.0.camel@that.guru> (raw)
In-Reply-To: <20171219054127.26494-1-andrew.donnellan@au1.ibm.com>
On Tue, 2017-12-19 at 16:41 +1100, Andrew Donnellan wrote:
> In profile.html, if settings.ENABLE_REST_API == False, trying to
> render a
> link to the generate_token page will raise a NoReverseMatch
> exception, so
> we shouldn't render that. In any case, if the REST API is disabled,
> we
> really shouldn't render the API token section of the page at all.
>
> Only render the API token and generation link if
> settings.ENABLE_REST_API
> is True.
>
> Cc: stable
> Reported-by: Tomas Novotny <tomas@novotny.cz>
> Closes: #138 ("NoReverseMatch exception on user login with disabled
> REST API")
> Fixes: 85c8f369204a ("views: Provide a way to view, (re)generate
> tokens")
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Looks good to me. Merged and backported to 'stable/2.0'.
Reviewed-by: Stephen Finucane <stephen@that.guru>
prev parent reply other threads:[~2018-01-04 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 5:41 [PATCH] views: Don't render token section of user profile if REST API disabled Andrew Donnellan
2017-12-19 5:52 ` Andrew Donnellan
2018-01-04 11:30 ` Stephen Finucane [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515065458.32193.0.camel@that.guru \
--to=stephen@that.guru \
--cc=andrew.donnellan@au1.ibm.com \
--cc=patchwork@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
--cc=tomas@novotny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).