From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "leon@kernel.org" <leon@kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>
Cc: "jgg@mellanox.com" <jgg@mellanox.com>,
"monis@mellanox.com" <monis@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] RDMA/rxe: Fix a race condition related to the QP error state
Date: Thu, 11 Jan 2018 16:02:33 +0000 [thread overview]
Message-ID: <1515686552.2752.2.camel@wdc.com> (raw)
In-Reply-To: <20180111062252.GP7368@mtr-leonro.local>
On Thu, 2018-01-11 at 08:22 +0200, Leon Romanovsky wrote:
> The proposed patch definitely decreases the chance of races, but it is not fixing them.
> There is a chance to have change in qp state immediately after your "if ..." check.
Hello Leon,
Please have a look at rxe_qp_error() and you will see that the patch I posted
is a proper fix. In the scenario you described rxe_qp_error() will trigger a
run of rxe_completer().
Bart.
next prev parent reply other threads:[~2018-01-11 16:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 19:23 [PATCH] RDMA/rxe: Fix a race condition related to the QP error state Bart Van Assche
2018-01-10 21:40 ` Doug Ledford
2018-01-10 22:01 ` Doug Ledford
2018-01-11 6:22 ` Leon Romanovsky
2018-01-11 16:02 ` Bart Van Assche [this message]
2018-01-11 19:00 ` Leon Romanovsky
2018-01-11 19:07 ` Bart Van Assche
2018-01-12 6:23 ` Leon Romanovsky
2018-01-12 6:32 ` Bart Van Assche
2018-01-12 6:38 ` Leon Romanovsky
2018-01-11 11:27 ` Moni Shoua
2018-01-11 16:16 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515686552.2752.2.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=monis@mellanox.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).