From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.hgst.iphmx.com ([68.232.141.245]:39434 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbeBVCX3 (ORCPT ); Wed, 21 Feb 2018 21:23:29 -0500 From: Damien Le Moal To: "jejb@linux.vnet.ibm.com" , Bart Van Assche , "martin.petersen@oracle.com" CC: "linux-scsi@vger.kernel.org" , "hare@suse.com" , "jthumshirn@suse.de" , "ptikhomirov@virtuozzo.com" , "ncopa@alpinelinux.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] Avoid that ATA error handling hangs Date: Thu, 22 Feb 2018 02:23:25 +0000 Message-ID: <1519266202.16203.5.camel@wdc.com> References: <20180221172316.11884-1-bart.vanassche@wdc.com> In-Reply-To: <20180221172316.11884-1-bart.vanassche@wdc.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <2814518F2B73EB418908138337C4D526@namprd04.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: QmFydCwNCg0KT24gV2VkLCAyMDE4LTAyLTIxIGF0IDA5OjIzIC0wODAwLCBCYXJ0IFZhbiBBc3Nj aGUgd3JvdGU6DQo+IEF2b2lkIHRoYXQgdGhlIHJlY2VudGx5IGludHJvZHVjZWQgY2FsbF9yY3Uo KSBjYWxsIGluIHRoZSBTQ1NJIGNvcmUNCj4gY2F1c2VzIHRoZSBSQ1UgY29yZSB0byBjb21wbGFp biBhYm91dCBkb3VibGUgY2FsbF9yY3UoKSBjYWxscy4NCj4gDQo+IFJlcG9ydGVkLWJ5OiBOYXRh bmFlbCBDb3BhIDxuY29wYUBhbHBpbmVsaW51eC5vcmc+DQo+IFJlcG9ydGVkLWJ5OiBEYW1pZW4g TGUgTW9hbCA8ZGFtaWVuLmxlbW9hbEB3ZGMuY29tPg0KPiBSZWZlcmVuY2VzOiBodHRwczovL2J1 Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODg2MQ0KPiBGaXhlczogM2JkNmY0 M2Y1Y2IzICgic2NzaTogY29yZTogRW5zdXJlIHRoYXQgdGhlIFNDU0kgZXJyb3IgaGFuZGxlciBn ZXRzDQo+IHdva2VuIHVwIikNCj4gU2lnbmVkLW9mZi1ieTogQmFydCBWYW4gQXNzY2hlIDxiYXJ0 LnZhbmFzc2NoZUB3ZGMuY29tPg0KPiBDYzogTmF0YW5hZWwgQ29wYSA8bmNvcGFAYWxwaW5lbGlu dXgub3JnPg0KPiBDYzogRGFtaWVuIExlIE1vYWwgPGRhbWllbi5sZW1vYWxAd2RjLmNvbT4NCj4g Q2M6IFBhdmVsIFRpa2hvbWlyb3YgPHB0aWtob21pcm92QHZpcnR1b3p6by5jb20+DQo+IENjOiBI YW5uZXMgUmVpbmVja2UgPGhhcmVAc3VzZS5jb20+DQo+IENjOiBKb2hhbm5lcyBUaHVtc2hpcm4g PGp0aHVtc2hpcm5Ac3VzZS5kZT4NCj4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPg0KPiAt LS0NCj4gIGRyaXZlcnMvc2NzaS9zY3NpX2Vycm9yLmMgfCA1ICsrKy0tDQo+ICBpbmNsdWRlL3Nj c2kvc2NzaV9jbW5kLmggIHwgMyArKysNCj4gIGluY2x1ZGUvc2NzaS9zY3NpX2hvc3QuaCAgfCAy IC0tDQo+ICAzIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkN Cj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Njc2kvc2NzaV9lcnJvci5jIGIvZHJpdmVycy9z Y3NpL3Njc2lfZXJyb3IuYw0KPiBpbmRleCBhZTMyNTk4NWVhYzEuLmFjOWNlMDk5NTMwZSAxMDA2 NDQNCj4gLS0tIGEvZHJpdmVycy9zY3NpL3Njc2lfZXJyb3IuYw0KPiArKysgYi9kcml2ZXJzL3Nj c2kvc2NzaV9lcnJvci5jDQo+IEBAIC0yMjksNyArMjI5LDggQEAgc3RhdGljIHZvaWQgc2NzaV9l aF9yZXNldChzdHJ1Y3Qgc2NzaV9jbW5kICpzY21kKQ0KPiAgDQo+ICBzdGF0aWMgdm9pZCBzY3Np X2VoX2luY19ob3N0X2ZhaWxlZChzdHJ1Y3QgcmN1X2hlYWQgKmhlYWQpDQo+ICB7DQo+IC0Jc3Ry dWN0IFNjc2lfSG9zdCAqc2hvc3QgPSBjb250YWluZXJfb2YoaGVhZCwgdHlwZW9mKCpzaG9zdCks IHJjdSk7DQo+ICsJc3RydWN0IHNjc2lfY21uZCAqc2NtZCA9IGNvbnRhaW5lcl9vZihoZWFkLCB0 eXBlb2YoKnNjbWQpLCByY3UpOw0KPiArCXN0cnVjdCBTY3NpX0hvc3QgKnNob3N0ID0gc2NtZC0+ ZGV2aWNlLT5ob3N0Ow0KPiAgCXVuc2lnbmVkIGxvbmcgZmxhZ3M7DQo+ICANCj4gIAlzcGluX2xv Y2tfaXJxc2F2ZShzaG9zdC0+aG9zdF9sb2NrLCBmbGFncyk7DQo+IEBAIC0yNjUsNyArMjY2LDcg QEAgdm9pZCBzY3NpX2VoX3NjbWRfYWRkKHN0cnVjdCBzY3NpX2NtbmQgKnNjbWQpDQo+ICAJICog RW5zdXJlIHRoYXQgYWxsIHRhc2tzIG9ic2VydmUgdGhlIGhvc3Qgc3RhdGUgY2hhbmdlIGJlZm9y ZSB0aGUNCj4gIAkgKiBob3N0X2ZhaWxlZCBjaGFuZ2UuDQo+ICAJICovDQo+IC0JY2FsbF9yY3Uo JnNob3N0LT5yY3UsIHNjc2lfZWhfaW5jX2hvc3RfZmFpbGVkKTsNCj4gKwljYWxsX3JjdSgmc2Nt ZC0+cmN1LCBzY3NpX2VoX2luY19ob3N0X2ZhaWxlZCk7DQo+ICB9DQo+ICANCj4gIC8qKg0KPiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9zY3NpL3Njc2lfY21uZC5oIGIvaW5jbHVkZS9zY3NpL3Njc2lf Y21uZC5oDQo+IGluZGV4IGQ4ZDRhOTAyYTg4ZC4uMjI4MGIyMzUxNzM5IDEwMDY0NA0KPiAtLS0g YS9pbmNsdWRlL3Njc2kvc2NzaV9jbW5kLmgNCj4gKysrIGIvaW5jbHVkZS9zY3NpL3Njc2lfY21u ZC5oDQo+IEBAIC02OCw2ICs2OCw5IEBAIHN0cnVjdCBzY3NpX2NtbmQgew0KPiAgCXN0cnVjdCBs aXN0X2hlYWQgbGlzdDsgIC8qIHNjc2lfY21uZCBwYXJ0aWNpcGF0ZXMgaW4gcXVldWUgbGlzdHMg Ki8NCj4gIAlzdHJ1Y3QgbGlzdF9oZWFkIGVoX2VudHJ5OyAvKiBlbnRyeSBmb3IgdGhlIGhvc3Qg ZWhfY21kX3EgKi8NCj4gIAlzdHJ1Y3QgZGVsYXllZF93b3JrIGFib3J0X3dvcms7DQo+ICsNCj4g KwlzdHJ1Y3QgcmN1X2hlYWQgcmN1Ow0KPiArDQo+ICAJaW50IGVoX2VmbGFnczsJCS8qIFVzZWQg YnkgZXJyb3IgaGFuZGxyICovDQo+ICANCj4gIAkvKg0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9z Y3NpL3Njc2lfaG9zdC5oIGIvaW5jbHVkZS9zY3NpL3Njc2lfaG9zdC5oDQo+IGluZGV4IDFhMWRm MGQyMWVlMy4uYThiN2JmODc5Y2VkIDEwMDY0NA0KPiAtLS0gYS9pbmNsdWRlL3Njc2kvc2NzaV9o b3N0LmgNCj4gKysrIGIvaW5jbHVkZS9zY3NpL3Njc2lfaG9zdC5oDQo+IEBAIC01NzEsOCArNTcx LDYgQEAgc3RydWN0IFNjc2lfSG9zdCB7DQo+ICAJCXN0cnVjdCBibGtfbXFfdGFnX3NldAl0YWdf c2V0Ow0KPiAgCX07DQo+ICANCj4gLQlzdHJ1Y3QgcmN1X2hlYWQgcmN1Ow0KPiAtDQo+ICAJYXRv bWljX3QgaG9zdF9idXN5OwkJICAgLyogY29tbWFuZHMgYWN0dWFsbHkgYWN0aXZlDQo+IG9uIGxv dy1sZXZlbCAqLw0KPiAgCWF0b21pY190IGhvc3RfYmxvY2tlZDsNCg0KVGhpcyBkb2VzIG5vdCBj b21waWxlLiBZb3UgbWlzc2VkIHRoZSBpbml0X3JjdV9oZWFkKCkgYW5kIGRlc3Ryb3lfcmN1X2hl YWQoKQ0KY2hhbmdlcy4gQWRkaW5nIHRoaXM6DQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL3Njc2kv aG9zdHMuYyBiL2RyaXZlcnMvc2NzaS9ob3N0cy5jDQppbmRleCA1N2JmNDNlMzQ4NjMuLmRkOTQ2 NDkyMDQ1NiAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvc2NzaS9ob3N0cy5jDQorKysgYi9kcml2ZXJz L3Njc2kvaG9zdHMuYw0KQEAgLTMyOCw4ICszMjgsNiBAQCBzdGF0aWMgdm9pZCBzY3NpX2hvc3Rf ZGV2X3JlbGVhc2Uoc3RydWN0IGRldmljZSAqZGV2KQ0KICAgICAgICBpZiAoc2hvc3QtPndvcmtf cSkNCiAgICAgICAgICAgICAgICBkZXN0cm95X3dvcmtxdWV1ZShzaG9zdC0+d29ya19xKTsNCiAN Ci0gICAgICAgZGVzdHJveV9yY3VfaGVhZCgmc2hvc3QtPnJjdSk7DQotDQogICAgICAgIGlmIChz aG9zdC0+c2hvc3Rfc3RhdGUgPT0gU0hPU1RfQ1JFQVRFRCkgew0KICAgICAgICAgICAgICAgIC8q DQogICAgICAgICAgICAgICAgICogRnJlZSB0aGUgc2hvc3RfZGV2IGRldmljZSBuYW1lIGhlcmUg aWYgc2NzaV9ob3N0X2FsbG9jKCkNCkBAIC00MDQsNyArNDAyLDYgQEAgc3RydWN0IFNjc2lfSG9z dCAqc2NzaV9ob3N0X2FsbG9jKHN0cnVjdA0Kc2NzaV9ob3N0X3RlbXBsYXRlICpzaHQsIGludCBw cml2c2l6ZSkNCiAgICAgICAgSU5JVF9MSVNUX0hFQUQoJnNob3N0LT5zdGFydmVkX2xpc3QpOw0K ICAgICAgICBpbml0X3dhaXRxdWV1ZV9oZWFkKCZzaG9zdC0+aG9zdF93YWl0KTsNCiAgICAgICAg bXV0ZXhfaW5pdCgmc2hvc3QtPnNjYW5fbXV0ZXgpOw0KLSAgICAgICBpbml0X3JjdV9oZWFkKCZz aG9zdC0+cmN1KTsNCiANCiAgICAgICAgaW5kZXggPSBpZGFfc2ltcGxlX2dldCgmaG9zdF9pbmRl eF9pZGEsIDAsIDAsIEdGUF9LRVJORUwpOw0KICAgICAgICBpZiAoaW5kZXggPCAwKQ0KZGlmZiAt LWdpdCBhL2RyaXZlcnMvc2NzaS9zY3NpX2xpYi5jIGIvZHJpdmVycy9zY3NpL3Njc2lfbGliLmMN CmluZGV4IGE4NmRmOWNhN2QxYy4uNDg4ZTVjOWFjZWRmIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9z Y3NpL3Njc2lfbGliLmMNCisrKyBiL2RyaXZlcnMvc2NzaS9zY3NpX2xpYi5jDQpAQCAtNTkwLDYg KzU5MCw4IEBAIHN0YXRpYyB2b2lkIHNjc2lfdW5pbml0X2NtZChzdHJ1Y3Qgc2NzaV9jbW5kICpj bWQpDQogICAgICAgICAgICAgICAgaWYgKGRydi0+dW5pbml0X2NvbW1hbmQpDQogICAgICAgICAg ICAgICAgICAgICAgICBkcnYtPnVuaW5pdF9jb21tYW5kKGNtZCk7DQogICAgICAgIH0NCisNCisg ICAgICAgZGVzdHJveV9yY3VfaGVhZCgmY21kLT5yY3UpOw0KIH0NCiANCiBzdGF0aWMgdm9pZCBz Y3NpX21xX2ZyZWVfc2d0YWJsZXMoc3RydWN0IHNjc2lfY21uZCAqY21kKQ0KQEAgLTExNTMsNiAr MTE1NSw3IEBAIHN0YXRpYyB2b2lkIHNjc2lfaW5pdGlhbGl6ZV9ycShzdHJ1Y3QgcmVxdWVzdCAq cnEpDQogICAgICAgIHNjc2lfcmVxX2luaXQoJmNtZC0+cmVxKTsNCiAgICAgICAgY21kLT5qaWZm aWVzX2F0X2FsbG9jID0gamlmZmllczsNCiAgICAgICAgY21kLT5yZXRyaWVzID0gMDsNCisgICAg ICAgaW5pdF9yY3VfaGVhZCgmY21kLT5yY3UpOw0KIH0NCiANCiAvKiBBZGQgYSBjb21tYW5kIHRv IHRoZSBsaXN0IHVzZWQgYnkgdGhlIGFhY3JhaWQgYW5kIGRwdF9pMm8gZHJpdmVycyAqLw0KDQpB bmQgaXQgY29tcGlsZXMuDQoNClRlc3RpbmcgdGhpcywgdGhlIHJjdSBoYW5nIGlzIG5vdyBnb25l Lg0KDQpIb3dldmVyLCB0aGUgYmVoYXZpb3Igb2YgdGhlIGVycm9yIHJlY292ZXJ5ICBpcyBzdGls bCBkaWZmZXJlbnQgZnJvbSB3aGF0IEkNCnNlZSBpbiA0LjE1IGFuZCA0LjE0LiBGb3IgbXkgdGVz dCBjYXNlLCBhbiB1bmFsaWduZWQgd3JpdGUgdG8gYSBzZXF1ZW50aWFsDQp6b25lIG9uIGEgWkFD IGRyaXZlIGNvbm5lY3RlZCB0byBhbiBBSENJIHBvcnQsIHRoZSByZXBvcnQgem9uZSBpc3N1ZWQg ZHVyaW5nDQp0aGUgZGlzayByZXZhbGlkYXRpb24gYWZ0ZXIgdGhlIHdyaXRlIGVycm9yIGZhaWxz IHdpdGggYSB0aW1lb3V0LCB3aGljaCBjYXVzZXMNCmNhcGFjaXR5IGNoYW5nZSB0byAwLCBwb3J0 IHJlc2V0IGFuZCByZWNvdmVyeSBhZ2Fpbi4gRXZlbnR1YWxseSwgZXZlcnl0aGluZw0KY29tZXMg YmFjayB1cCBPSywgYnV0IGl0IHRha2VzIHNvbWUgdGltZS4NCg0KSSBhbSBpbnZlc3RpZ2F0aW5n IHRvIG1ha2Ugc3VyZSBJIGFtIG5vdCBoaXR0aW5nIGEgZGV2aWNlIEZXIGJ1ZyB0byBjb25maXJt IGlmDQp0aGlzIGlzIGEga2VybmVsIHByb2JsZW0uDQoNCkJlc3QgcmVnYXJkcy4NCg0KLS0gDQpE YW1pZW4gTGUgTW9hbA0KV2VzdGVybiBEaWdpdGFs