From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34484 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbeBWLLV (ORCPT ); Fri, 23 Feb 2018 06:11:21 -0500 Subject: Patch "IB/hfi1: Initialize bth1 in 16B rc ack builder" has been added to the 4.14-stable tree To: dennis.dalessandro@intel.com, alexander.levin@verizon.com, don.hiatt@intel.com, gregkh@linuxfoundation.org, jgg@mellanox.com Cc: , From: Date: Fri, 23 Feb 2018 12:10:28 +0100 Message-ID: <151938422825435@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled IB/hfi1: Initialize bth1 in 16B rc ack builder to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ib-hfi1-initialize-bth1-in-16b-rc-ack-builder.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From foo@baz Fri Feb 23 11:45:09 CET 2018 From: Dennis Dalessandro Date: Tue, 14 Nov 2017 04:34:23 -0800 Subject: IB/hfi1: Initialize bth1 in 16B rc ack builder From: Dennis Dalessandro [ Upstream commit 8935780b9f7bbad0f2eb5dd43f61ba7b509a1575 ] It is possible the bth1 variable could be used uninitialized so going ahead and giving it a default value. Otherwise we leak stack memory to the network. Fixes: 5b6cabb0db77 ("IB/hfi1: Add 16B RC/UC support") Reviewed-by: Don Hiatt Signed-off-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/hfi1/rc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/infiniband/hw/hfi1/rc.c +++ b/drivers/infiniband/hw/hfi1/rc.c @@ -815,7 +815,7 @@ static inline void hfi1_make_rc_ack_16B( struct hfi1_pportdata *ppd = ppd_from_ibp(ibp); struct hfi1_16b_header *hdr = &opa_hdr->opah; struct ib_other_headers *ohdr; - u32 bth0, bth1; + u32 bth0, bth1 = 0; u16 len, pkey; u8 becn = !!is_fecn; u8 l4 = OPA_16B_L4_IB_LOCAL; Patches currently in stable-queue which might be from dennis.dalessandro@intel.com are queue-4.14/ib-hfi1-initialize-bth1-in-16b-rc-ack-builder.patch