public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* Patch "IB/hfi1: Initialize bth1 in 16B rc ack builder" has been added to the 4.14-stable tree
@ 2018-02-23 11:10 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2018-02-23 11:10 UTC (permalink / raw)
  To: dennis.dalessandro, alexander.levin, don.hiatt, gregkh, jgg
  Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    IB/hfi1: Initialize bth1 in 16B rc ack builder

to the 4.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ib-hfi1-initialize-bth1-in-16b-rc-ack-builder.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Fri Feb 23 11:45:09 CET 2018
From: Dennis Dalessandro <dennis.dalessandro@intel.com>
Date: Tue, 14 Nov 2017 04:34:23 -0800
Subject: IB/hfi1: Initialize bth1 in 16B rc ack builder

From: Dennis Dalessandro <dennis.dalessandro@intel.com>


[ Upstream commit 8935780b9f7bbad0f2eb5dd43f61ba7b509a1575 ]

It is possible the bth1 variable could be used uninitialized so going
ahead and giving it a default value.

Otherwise we leak stack memory to the network.

Fixes: 5b6cabb0db77 ("IB/hfi1: Add 16B RC/UC support")
Reviewed-by: Don Hiatt <don.hiatt@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/infiniband/hw/hfi1/rc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/infiniband/hw/hfi1/rc.c
+++ b/drivers/infiniband/hw/hfi1/rc.c
@@ -815,7 +815,7 @@ static inline void hfi1_make_rc_ack_16B(
 	struct hfi1_pportdata *ppd = ppd_from_ibp(ibp);
 	struct hfi1_16b_header *hdr = &opa_hdr->opah;
 	struct ib_other_headers *ohdr;
-	u32 bth0, bth1;
+	u32 bth0, bth1 = 0;
 	u16 len, pkey;
 	u8 becn = !!is_fecn;
 	u8 l4 = OPA_16B_L4_IB_LOCAL;


Patches currently in stable-queue which might be from dennis.dalessandro@intel.com are

queue-4.14/ib-hfi1-initialize-bth1-in-16b-rc-ack-builder.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-02-23 11:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 11:10 Patch "IB/hfi1: Initialize bth1 in 16B rc ack builder" has been added to the 4.14-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox