From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailgw01.mediatek.com ([210.61.82.183]:43422 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751036AbeCGJVu (ORCPT ); Wed, 7 Mar 2018 04:21:50 -0500 Message-ID: <1520414499.677.5.camel@mtkswgap22> Subject: Re: [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added From: Sean Wang To: CC: , , , , , , , Date: Wed, 7 Mar 2018 17:21:39 +0800 In-Reply-To: <9d9d75250bf62b491294a0c550c35ab7aba05eef.1518113047.git.sean.wang@mediatek.com> References: <9d9d75250bf62b491294a0c550c35ab7aba05eef.1518113047.git.sean.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: Hi, Matthis also a gentle ping for the patch Sean On Fri, 2018-02-09 at 02:07 +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > Fix the pointer to struct scp_subdomian not being moved forward > when each sub-domain is expected to be iteratively added through > pm_genpd_add_subdomain call. > > Cc: stable@vger.kernel.org > Fixes: 53fddb1a66dd ("soc: mediatek: reduce code duplication of scpsys_probe across all SoCs") > Reported-by: Weiyi Lu > Signed-off-by: Sean Wang > --- > drivers/soc/mediatek/mtk-scpsys.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c > index fc55faa..9de801e 100644 > --- a/drivers/soc/mediatek/mtk-scpsys.c > +++ b/drivers/soc/mediatek/mtk-scpsys.c > @@ -1048,7 +1048,7 @@ static int scpsys_probe(struct platform_device *pdev) > > pd_data = &scp->pd_data; > > - for (i = 0, sd = soc->subdomains ; i < soc->num_subdomains ; i++) { > + for (i = 0, sd = soc->subdomains; i < soc->num_subdomains; i++, sd++) { > ret = pm_genpd_add_subdomain(pd_data->domains[sd->origin], > pd_data->domains[sd->subdomain]); > if (ret && IS_ENABLED(CONFIG_PM))