From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbeCHRhz (ORCPT ); Thu, 8 Mar 2018 12:37:55 -0500 Subject: Patch "Revert "led: core: Fix brightness setting when setting delay_off=0"" has been added to the 4.4-stable tree To: ben.hutchings@codethink.co.uk, gregkh@linuxfoundation.org, jacek.anaszewski@gmail.com, matthieu.castet@parrot.com Cc: , From: Date: Thu, 08 Mar 2018 09:37:56 -0800 In-Reply-To: <20180308155906.5zaldlnuxvxmh2wo@xylophone.i.decadent.org.uk> Message-ID: <1520530676222111@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled Revert "led: core: Fix brightness setting when setting delay_off=0" to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-led-core-fix-brightness-setting-when-setting-delay_off-0.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From ben.hutchings@codethink.co.uk Thu Mar 8 09:31:04 2018 From: Ben Hutchings Date: Thu, 8 Mar 2018 15:59:07 +0000 Subject: Revert "led: core: Fix brightness setting when setting delay_off=0" To: Greg Kroah-Hartman Cc: Jacek Anaszewski , Matthieu CASTET , stable@vger.kernel.org Message-ID: <20180308155906.5zaldlnuxvxmh2wo@xylophone.i.decadent.org.uk> Content-Disposition: inline From: Ben Hutchings This reverts commit 20ac8f72514b3af8b62c520d55656ded865eff00, which was commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c upstream. The bug that it should fix was only introduced in Linux 4.7, and in 4.4 it causes a regression. Reported-by: Jacek Anaszewski Cc: Matthieu CASTET Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/leds/led-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -149,7 +149,7 @@ void led_blink_set(struct led_classdev * unsigned long *delay_on, unsigned long *delay_off) { - led_stop_software_blink(led_cdev); + del_timer_sync(&led_cdev->blink_timer); led_cdev->flags &= ~LED_BLINK_ONESHOT; led_cdev->flags &= ~LED_BLINK_ONESHOT_STOP; Patches currently in stable-queue which might be from ben.hutchings@codethink.co.uk are queue-4.4/x86-spectre-fix-an-error-message.patch queue-4.4/revert-led-core-fix-brightness-setting-when-setting-delay_off-0.patch queue-4.4/x86-apic-vector-handle-legacy-irq-data-correctly.patch