From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap1.codethink.co.uk ([176.9.8.82]:46915 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbeCTXTo (ORCPT ); Tue, 20 Mar 2018 19:19:44 -0400 Message-ID: <1521587979.23626.117.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 29/63] watchdog: hpwdt: fix unused variable warning From: Ben Hutchings To: Greg Kroah-Hartman , Jerry Hoemann Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Arnd Bergmann , Guenter Roeck , Wim Van Sebroeck Date: Tue, 20 Mar 2018 23:19:39 +0000 In-Reply-To: <20180318101416.GD13276@kroah.com> References: <20180316152259.964532775@linuxfoundation.org> <20180316152303.262268098@linuxfoundation.org> <20180316225537.GA5989@anatevka.americas.hpqcorp.net> <20180318101416.GD13276@kroah.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Sun, 2018-03-18 at 11:14 +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 16, 2018 at 04:55:37PM -0600, Jerry Hoemann wrote: > > > > Greg, > > > > Sorry, if I'm missing something, but I see 3 patches for > > hpwdt queued up for 4.4: > > > > queue-4.4/watchdog-hpwdt-fix-unused-variable-warning.patch > > queue-4.4/watchdog-hpwdt-smbios-check.patch > > queue-4.4/watchdog-hpwdt-check-source-of-nmi.patch > > > > > > Shouldn't there also be a 4.4 patch for > > > > commit 2b3d89b402b085b08498e896c65267a145bed486 > > watchdog: hpwdt: Remove legacy NMI sourcing. > > > > As there was for 4.15, 4.14, and 4.9? > > It does not apply to the 4.4.y kernel branch.  If you feel it should be > there, please provide a working backport. > > > commit 2b3d89b40 is the Spectre related patch. > > If you look closely, not many Spectre-related patches are merged into > 4.4.y as no one has taken the time to do the backporting.  I thought > someone was working on this, but odds are they just moved to 4.9.y or > 4.14.y as everyone really should if they care about these issues with > their platforms. > > So if you care about Spectre, I strongly recommend using 4.14.y or > newer. I think you have most of the Spectre stuff aside from microcode supported fixes. These are still missing on the 4.4 branch though: 8fa80c503b48 nospec: Move array_index_nospec() parameter checking into separate macro 1d91c1d2c80c nospec: Kill array_index_nospec_mask_check() I think there may also be some extra uaccess functions that didn't get the nospec treatment. I'll probably look into backporting the microcode stuff to the older branches (4.4, then 3.16 and 3.2) at some point. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.