[PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME

[PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME

[Vic Wei]

QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.

Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c
Signed-off-by: Vic Wei <vwei@codeaurora.org>
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 60bf04b..b94ff37 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3050,6 +3050,7 @@ static int btusb_probe(struct usb_interface *intf,
 	if (id->driver_info & BTUSB_QCA_ROME) {
 		data->setup_on_usb = btusb_setup_qca;
 		hdev->set_bdaddr = btusb_set_bdaddr_ath3012;
+		set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks);
 	}
 
 #ifdef CONFIG_BT_HCIBTUSB_RTL
-- 
1.9.1

Re: [PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME

[Greg KH]

On Wed, Mar 21, 2018 at 09:09:57AM -0700, Vic Wei wrote:
> QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.
> 
> Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c

What is this line for?

> Signed-off-by: Vic Wei <vwei@codeaurora.org>
> ---
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Re: [PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME

[Harsh Shandilya]

On 21 March 2018 9:54:37 PM IST, Greg KH <gregkh@linuxfoundation.org> wrote:
>On Wed, Mar 21, 2018 at 09:09:57AM -0700, Vic Wei wrote:
>> QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.
>> 
>> Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c
>
>What is this line for?

That's the Change ID required by everything that goes through Gerrit. CAF (I'm assuming Vic is from CodeAurora Forums judging by the email) uses Gerrit as their review platform for the Android for MSM project.

Re: [PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME

[Greg KH]

On Wed, Mar 21, 2018 at 11:40:07PM +0530, Harsh Shandilya wrote:
> 
> 
> On 21 March 2018 9:54:37 PM IST, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Wed, Mar 21, 2018 at 09:09:57AM -0700, Vic Wei wrote:
> >> QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.
> >> 
> >> Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c
> >
> >What is this line for?
> 
> That's the Change ID required by everything that goes through Gerrit. CAF (I'm assuming Vic is from CodeAurora Forums judging by the email) uses Gerrit as their review platform for the Android for MSM project.

It was a rhetorical question, I know what it is, and the fact that it
should not be in a kernel patch submission, I wanted the submitter to
learn to read their own patches _before_ they send them in.

Also, if they used checkpatch.pl, it would have told them to remove
this.

It's like saying to a kid, "what is this mess on the floor"...

greg k-h