From: Max Gurtovoy <maxg@mellanox.com>
To: idanb@mellanox.com, oren@mellanox.com, israelr@mellanox.com,
nitzanc@mellanox.com, leonro@mellanox.com, jgg@mellanox.com,
sergeygo@mellanox.com
Cc: vladimirk@mellanox.com, linux-internal@mellanox.com,
Max Gurtovoy <maxg@mellanox.com>,
stable@vger.kernel.org
Subject: [PATCH 01/17] IB/isert: fix T10-pi check mask setting
Date: Thu, 24 May 2018 22:49:21 +0300 [thread overview]
Message-ID: <1527191377-11513-2-git-send-email-maxg@mellanox.com> (raw)
In-Reply-To: <1527191377-11513-1-git-send-email-maxg@mellanox.com>
A copy/paste bug (probably) caused setting of an app_tag check mask
in case where a ref_tag check was needed.
Fixes: 38a2d0d429f1 ("IB/isert: convert to the generic RDMA READ/WRITE API")
Fixes: 9e961ae73c2c ("IB/isert: Support T10-PI protected transactions")
Cc: stable@vger.kernel.org
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
---
drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index fff40b0..d8b6bde 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -2108,7 +2108,7 @@
sig_attrs->check_mask =
(se_cmd->prot_checks & TARGET_DIF_CHECK_GUARD ? 0xc0 : 0) |
- (se_cmd->prot_checks & TARGET_DIF_CHECK_REFTAG ? 0x30 : 0) |
+ (se_cmd->prot_checks & TARGET_DIF_CHECK_APPTAG ? 0x30 : 0) |
(se_cmd->prot_checks & TARGET_DIF_CHECK_REFTAG ? 0x0f : 0);
return 0;
}
--
1.8.3.1
next parent reply other threads:[~2018-05-24 19:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527191377-11513-1-git-send-email-maxg@mellanox.com>
2018-05-24 19:49 ` Max Gurtovoy [this message]
[not found] <1527436222-15494-1-git-send-email-maxg@mellanox.com>
2018-05-27 15:50 ` [PATCH 01/17] IB/isert: fix T10-pi check mask setting Max Gurtovoy
2018-05-28 7:21 ` Christoph Hellwig
2018-05-28 11:54 ` Max Gurtovoy
2018-05-28 12:03 ` Christoph Hellwig
2018-05-28 12:04 ` Max Gurtovoy
2018-05-28 16:33 ` Jason Gunthorpe
2018-05-29 3:01 ` Martin K. Petersen
2018-05-29 12:08 ` Max Gurtovoy
2018-05-29 19:23 ` Jason Gunthorpe
2018-05-29 22:11 ` Martin K. Petersen
2018-05-29 22:19 ` Jason Gunthorpe
2018-05-29 22:41 ` Martin K. Petersen
2018-05-30 8:07 ` Max Gurtovoy
2018-05-30 15:30 ` Jason Gunthorpe
2018-05-30 21:47 ` Sagi Grimberg
2018-05-30 21:49 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527191377-11513-2-git-send-email-maxg@mellanox.com \
--to=maxg@mellanox.com \
--cc=idanb@mellanox.com \
--cc=israelr@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-internal@mellanox.com \
--cc=nitzanc@mellanox.com \
--cc=oren@mellanox.com \
--cc=sergeygo@mellanox.com \
--cc=stable@vger.kernel.org \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).