From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap1.codethink.co.uk ([176.9.8.82]:51637 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726720AbeILBDk (ORCPT ); Tue, 11 Sep 2018 21:03:40 -0400 Message-ID: <1536696163.3024.146.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 47/79] ieee802154: at86rf230: switch from BUG_ON() to WARN_ON() on problem From: Ben Hutchings To: Stefan Schmidt , Sasha Levin Cc: Greg Kroah-Hartman , LKML , stable Date: Tue, 11 Sep 2018 21:02:43 +0100 In-Reply-To: <20180823074922.172707485@linuxfoundation.org> References: <20180823074918.641878835@linuxfoundation.org> <20180823074922.172707485@linuxfoundation.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On Thu, 2018-08-23 at 09:53 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > ------------------ > > From: Stefan Schmidt > > [ Upstream commit 20f330452ad8814f2289a589baf65e21270879a7 ] > > The check is valid but it does not warrant to crash the kernel. A > WARN_ON() is good enough here. > Found by checkpatch. If the BUG/WARN fires, the very next statement is going to cause an oops. So this doesn't fix anything. Either it's OK for a null pointer to be a fatal error, in which case the WARN can be removed, or that shouldn't be a fatal error, in which case the following assignment needs to be conditional. Ben. > Signed-off-by: Stefan Schmidt > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman > --- >  drivers/net/ieee802154/at86rf230.c |    2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/ieee802154/at86rf230.c > +++ b/drivers/net/ieee802154/at86rf230.c > @@ -932,7 +932,7 @@ at86rf230_xmit(struct ieee802154_hw *hw, >  static int >  at86rf230_ed(struct ieee802154_hw *hw, u8 *level) >  { > - BUG_ON(!level); > + WARN_ON(!level); >   *level = 0xbe; >   return 0; >  } -- Ben Hutchings, Software Developer   Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom