From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:36000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727613AbeJUXXU (ORCPT ); Sun, 21 Oct 2018 19:23:20 -0400 From: Masami Hiramatsu To: Steven Rostedt , Shuah Khan Cc: Rajvi Jingar , Tom Zanussi , Masami Hiramatsu , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tom Zanussi Subject: [PATCH 1/2] tracing: Return -ENOENT if there is no target synthetic event Date: Mon, 22 Oct 2018 00:08:20 +0900 Message-Id: <154013449986.25576.9487131386597290172.stgit@devbox> In-Reply-To: <154013446976.25576.14780785912268176178.stgit@devbox> References: <154013446976.25576.14780785912268176178.stgit@devbox> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Return -ENOENT error if there is no target synthetic event. This notices an operation failure to user as below; # echo 'wakeup_latency u64 lat; pid_t pid;' > synthetic_events # echo '!wakeup' >> synthetic_events sh: write error: No such file or directory Fixes: 4b147936fa50 ('tracing: Add support for 'synthetic' events') Signed-off-by: Masami Hiramatsu Cc: stable@vger.kernel.org Cc: Tom Zanussi Cc: Steven Rostedt --- kernel/trace/trace_events_hist.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index d239004aaf29..eb908ef2ecec 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1063,8 +1063,10 @@ static int create_synth_event(int argc, char **argv) event = NULL; ret = -EEXIST; goto out; - } else if (delete_event) + } else if (delete_event) { + ret = -ENOENT; goto out; + } if (argc < 2) { ret = -EINVAL;