From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>, Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader.
Date: Tue, 18 Dec 2018 14:37:09 +0100 [thread overview]
Message-ID: <1545140229.18594.3.camel@suse.com> (raw)
In-Reply-To: <20181218123840.GP20658@localhost>
On Di, 2018-12-18 at 13:38 +0100, Johan Hovold wrote:
> On
> > @@ -1655,7 +1662,10 @@ static int acm_pre_reset(struct usb_interface *intf)
> > .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > },
> > { USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */
> > - .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > + .driver_info = DISABLE_ECHO, /* DISABLE ECHO in termios flag */
>
> I just noticed that you remove the NO_UNION_NORMAL here, which looks
> wrong and definitely requires a motivation.
>
> Thanks,
> Johan
>
Hi,
thank you and thank you Johan.
Unfortunately I cannot take this until the issue with the removed
quirk is clarified.
Regards
Oliver
next prev parent reply other threads:[~2018-12-18 13:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1544671676-23912-1-git-send-email-macpaul.lin@mediatek.com>
2018-12-18 5:00 ` [PATCH v2] cdc-acm: fix abnormal DATA RX issue for Mediatek Preloader Macpaul Lin
2018-12-18 9:02 ` Johan Hovold
2018-12-18 10:41 ` [PATCH v3] " Macpaul Lin
2018-12-18 10:54 ` Johan Hovold
2018-12-18 11:38 ` [PATCH v4] " Macpaul Lin
2018-12-18 11:44 ` Johan Hovold
2018-12-18 11:59 ` [PATCH v5] " Macpaul Lin
2018-12-18 12:38 ` Johan Hovold
2018-12-18 13:37 ` Oliver Neukum [this message]
2018-12-18 14:26 ` Macpaul Lin
2018-12-18 15:19 ` Macpaul Lin
2018-12-18 16:42 ` Lars Melin
2018-12-18 17:48 ` Macpaul Lin
2018-12-19 0:45 ` Lars Melin
2018-12-19 2:22 ` Macpaul Lin
2018-12-19 3:16 ` Macpaul Lin
2018-12-19 3:31 ` Lars Melin
2018-12-19 4:03 ` Macpaul Lin
2018-12-19 8:56 ` Oliver Neukum
2018-12-20 15:19 ` Greg Kroah-Hartman
2018-12-18 15:37 ` [PATCH v6] " Macpaul Lin
2018-12-19 4:11 ` [PATCH v7] " Macpaul Lin
2018-12-19 9:00 ` Johan Hovold
2018-12-20 15:28 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545140229.18594.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=stable@vger.kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).