From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:43314 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726379AbeLRNhU (ORCPT <rfc822;stable@vger.kernel.org>);
        Tue, 18 Dec 2018 08:37:20 -0500
Message-ID: <1545140229.18594.3.camel@suse.com>
Subject: Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek
 Preloader.
From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>,
        Macpaul Lin <macpaul.lin@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
        linux-usb@vger.kernel.org, stable@vger.kernel.org
Date: Tue, 18 Dec 2018 14:37:09 +0100
In-Reply-To: <20181218123840.GP20658@localhost>
References: <1544671676-23912-1-git-send-email-macpaul.lin@mediatek.com>
         <1545134386-5528-1-git-send-email-macpaul.lin@mediatek.com>
         <20181218123840.GP20658@localhost>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Di, 2018-12-18 at 13:38 +0100, Johan Hovold wrote:
> On 
> > @@ -1655,7 +1662,10 @@ static int acm_pre_reset(struct usb_interface *intf)
> >  	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> >  	},
> >  	{ USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */
> > -	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > +	.driver_info = DISABLE_ECHO, /* DISABLE ECHO in termios flag */
> 
> I just noticed that you remove the NO_UNION_NORMAL here, which looks
> wrong and definitely requires a motivation.
> 
> Thanks,
> Johan
> 

Hi,

thank you and thank you Johan.
Unfortunately I cannot take this until the issue with the removed
quirk is clarified.

	Regards
		Oliver