From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mailgw02.mediatek.com ([210.61.82.184]:62147 "EHLO
        mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
        with ESMTP id S1727071AbeLRO0o (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 18 Dec 2018 09:26:44 -0500
Message-ID: <1545143195.10193.6.camel@mtkswgap22>
Subject: Re: [PATCH v5] cdc-acm: fix abnormal DATA RX issue for Mediatek
 Preloader.
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Oliver Neukum <oneukum@suse.com>,
        Andrey Arapov <andrey.arapov@gmail.com>
CC: Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
        <linux-usb@vger.kernel.org>, <stable@vger.kernel.org>
Date: Tue, 18 Dec 2018 22:26:35 +0800
In-Reply-To: <1545140229.18594.3.camel@suse.com>
References: <1544671676-23912-1-git-send-email-macpaul.lin@mediatek.com>
         <1545134386-5528-1-git-send-email-macpaul.lin@mediatek.com>
         <20181218123840.GP20658@localhost> <1545140229.18594.3.camel@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, 2018-12-18 at 14:37 +0100, Oliver Neukum wrote:
> On Di, 2018-12-18 at 13:38 +0100, Johan Hovold wrote:
> > On 
> > > @@ -1655,7 +1662,10 @@ static int acm_pre_reset(struct usb_interface *intf)
> > >  	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > >  	},
> > >  	{ USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */
> > > -	.driver_info = NO_UNION_NORMAL, /* has no union descriptor */
> > > +	.driver_info = DISABLE_ECHO, /* DISABLE ECHO in termios flag */
> > 
> > I just noticed that you remove the NO_UNION_NORMAL here, which looks
> > wrong and definitely requires a motivation.
> > 
> > Thanks,
> > Johan
> > 
> 
> Hi,
> 
> thank you and thank you Johan.
> Unfortunately I cannot take this until the issue with the removed
> quirk is clarified.
> 
> 	Regards
> 		Oliver
> 

Hi,
Thanks Johan's help on reviewing the updated patches.
According to Andrey's patch, the commit said this change is for
"Samsung X180 China cellphone" which might be also a Mediatek SoC based
phone using Mediatek VID.
https://goo.gl/a9ddNq (I've add a url for reference here).

But I'm not sure the PID is for Mediatek's BROM or customized Preloader.
(Both should be able to apply DISABLE_ECHO flag).
Maybe I can simply update PATCH v6 by removing FIREFLY if any one has
problem here.
Let's also loop Andrey for clarification.

Thanks!

Regards,
Macpaul Lin