From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B447BC43387 for ; Tue, 15 Jan 2019 08:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7960420656 for ; Tue, 15 Jan 2019 08:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547541951; bh=MGjMAAlvqqR2YH05c5RTTftcd9UOAvYhAvf0cdz4aRU=; h=Subject:To:Cc:From:Date:List-ID:From; b=Lo8SlsaV0TJSD2rMuDtGALUmd3vebgNB/CKacPrtM4jSTiVEsWlvg9LJc3GSGII9V f59Mjq9NzrUOF4EdEnynMGk/1wD7BFGlpc0eaKBWP2APNSn9jle6apmTdL+00w89uL TPjc9LFaPerctQeDKC+6hCLe8HkPlPObD2jXxsmo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728456AbfAOIpv (ORCPT ); Tue, 15 Jan 2019 03:45:51 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:38809 "EHLO new3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727221AbfAOIpv (ORCPT ); Tue, 15 Jan 2019 03:45:51 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 1A66318168; Tue, 15 Jan 2019 03:45:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 15 Jan 2019 03:45:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=/z9FWl duJ7aI1L6d78aPgLllk28eZC454TDslZOcUUw=; b=vToUYZ5gWa6ztTc7klLRbS RlnBNgUoFKWtOqd+K0dq2rC/8TRNIBZG2VJGrEwSCYq8+rycHk5xEeklAjAxxj92 5hpeuroCJP4K/Rml2q6eZmlqz7Qo5sPl75GDjUIVNgPOpFEUELysNkO0awFNj4sE c9OzDgtGJEtbg0H4NbwQSOsFpzKSPeTYJNXQuKCeTlUvL9av9ug3G8eky9zTl2Yj 9U3JSoLZ2DPG0QCp18bPPmfaRsLxTosdauMPwFwKnd0B3zueBqmF3jUTeA45xKsQ JaynBYpq/pqgeCNfFxDLWNKs2Duf2yZVrLthjD65dqpRQA+NVnvK1/mOb0x7TL0Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedvgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecuogfuphgrmhfkphculdeftddtmdenucfjughrpefuvffhfffkgggtgfesthekre dttddtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdr ohhrgheqnecukfhppeekfedrkeeirdekledruddtjeenucfrrghrrghmpehmrghilhhfrh homhepghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 26580100E5; Tue, 15 Jan 2019 03:45:49 -0500 (EST) Subject: FAILED: patch "[PATCH] ext4: track writeback errors using the generic tracking" failed to apply to 3.18-stable tree To: tytso@mit.edu Cc: From: Date: Tue, 15 Jan 2019 09:44:57 +0100 Message-ID: <154754189720836@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 3.18-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 95cb67138746451cc84cf8e516e14989746e93b0 Mon Sep 17 00:00:00 2001 From: Theodore Ts'o Date: Mon, 31 Dec 2018 00:11:07 -0500 Subject: [PATCH] ext4: track writeback errors using the generic tracking infrastructure We already using mapping_set_error() in fs/ext4/page_io.c, so all we need to do is to use file_check_and_advance_wb_err() when handling fsync() requests in ext4_sync_file(). Signed-off-by: Theodore Ts'o Cc: stable@kernel.org diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 87a7ff00ef62..712f00995390 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -164,6 +164,9 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync) ret = err; } out: + err = file_check_and_advance_wb_err(file); + if (ret == 0) + ret = err; trace_ext4_sync_file_exit(inode, ret); return ret; }