From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F01ECC282C3 for ; Tue, 22 Jan 2019 16:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C949820823 for ; Tue, 22 Jan 2019 16:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728828AbfAVQE3 (ORCPT ); Tue, 22 Jan 2019 11:04:29 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43902 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728956AbfAVQE3 (ORCPT ); Tue, 22 Jan 2019 11:04:29 -0500 Received: by mail-pf1-f196.google.com with SMTP id w73so11964264pfk.10; Tue, 22 Jan 2019 08:04:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=9wH6sD9lk7MDVL9DRj0JPYtnqNdz9dFB9DSP6e5R9x8=; b=hVKbqQ75JS+pVJ9pz6S/XhMCGNEnnQw2d/MLkqu6PjICumQ6ToXd54fq3OUEoNOi5D aau5V4aSpRHpd46dqRZFmQMuk0RPlo4RR5x4jCbpl8Af/QCDR/WJ1U70mzgF4AXn19UD 87haXawKtCXHFplMvvniGuqOHx+b03POnzxouTKmozBejn43Wjg3TIzm3jrXD5HWIjo9 9KA6koJmq+MPFJBmn8RUiLayzz/nM/7xpzXreptIoAjsFd16wIOILzPxpeubQNinembk 8nmAgoELcwV+wFyFjF4GTOiQB0R9XpZOtF2tam4qhVAF46r1I9z6a+LqMrxDLa2x0UoQ oCFg== X-Gm-Message-State: AJcUukfRivgiLldJ9XwBd+5bJXEWis51F3VBVl1Pji0JFNOxQIFh0L3C o3Iq/zFsVysHsX+sE9gC2XyfW3Qg X-Google-Smtp-Source: ALg8bN4vsTVah3SwDTFg5K21m7Gsy1gCpik7NgyhTxb+bdCUgToRKJ/3moOsjOUoNS1erF2w2or+ig== X-Received: by 2002:a62:4641:: with SMTP id t62mr33641884pfa.141.1548173067915; Tue, 22 Jan 2019 08:04:27 -0800 (PST) Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id w136sm22397207pfd.169.2019.01.22.08.04.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Jan 2019 08:04:27 -0800 (PST) Message-ID: <1548173066.9266.47.camel@acm.org> Subject: Re: [PATCH 2/2] RDMA/srp: Rework SCSI device reset handling From: Bart Van Assche To: Sasha Levin , Jason Gunthorpe Cc: Doug Ledford , linux-rdma@vger.kernel.org, Sergey Gorenko , Max Gurtovoy , Laurence Oberman , stable@vger.kernel.org Date: Tue, 22 Jan 2019 08:04:26 -0800 In-Reply-To: <20190122155559.D1DD9217D6@mail.kernel.org> References: <20190117002717.84686-3-bvanassche@acm.org> <20190122155559.D1DD9217D6@mail.kernel.org> Content-Type: text/plain; charset="UTF-7" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, 2019-01-22 at 15:55 +-0000, Sasha Levin wrote: +AD4 +AFs-This is an automated email+AF0 +AD4 +AD4 This commit has been processed because it contains a +ACI-Fixes:+ACI tag, +AD4 fixing commit: 94a9174c630c IB/srp: reduce lock coverage of command completion. +AD4 +AD4 The bot has tested the following trees: v4.20.3, v4.19.16, v4.14.94, v4.9.151, v4.4.171, v3.18.132. +AD4 +AD4 v4.20.3: Build OK+ACE +AD4 v4.19.16: Build OK+ACE +AD4 v4.14.94: Build OK+ACE +AD4 v4.9.151: Build failed+ACE Errors: +AD4 drivers/infiniband/ulp/srp/ib+AF8-srp.c:2657:2: error: implicit declaration of function +IBg-blk+AF8-freeze+AF8-queue+AF8-start+IBkAOw did you mean +IBg-blk+AF8-mq+AF8-freeze+AF8-queue+AF8-start+IBk? +AFs--Werror+AD0-implicit-function-declaration+AF0 +AD4 drivers/infiniband/ulp/srp/ib+AF8-srp.c:2658:14: error: implicit declaration of function +IBg-blk+AF8-mq+AF8-freeze+AF8-queue+AF8-wait+AF8-timeout+IBkAOw did you mean +IBg-blk+AF8-mq+AF8-freeze+AF8-queue+AF8-start+IBk? +AFs--Werror+AD0-implicit-function- +AD4 declaration+AF0 +AD4 +AD4 v4.4.171: Build failed+ACE Errors: +AD4 drivers/infiniband/ulp/srp/ib+AF8-srp.c:2612:2: error: implicit declaration of function +IBg-blk+AF8-freeze+AF8-queue+AF8-start+IBkAOw did you mean +IBg-blk+AF8-mq+AF8-freeze+AF8-queue+AF8-start+IBk? +AFs--Werror+AD0-implicit-function-declaration+AF0 +AD4 drivers/infiniband/ulp/srp/ib+AF8-srp.c:2613:14: error: implicit declaration of function +IBg-blk+AF8-mq+AF8-freeze+AF8-queue+AF8-wait+AF8-timeout+IBkAOw did you mean +IBg-blk+AF8-mq+AF8-freeze+AF8-queue+AF8-start+IBk? +AFs--Werror+AD0-implicit-function- +AD4 declaration+AF0 +AD4 +AD4 v3.18.132: Failed to apply+ACE Possible dependencies: +AD4 205619f2f824 (+ACI-IB/srp: Remove stale connection retry mechanism+ACI) +AD4 34aa654ecb8e (+ACI-IB/srp: Avoid that I/O hangs due to a cable pull during LUN scanning+ACI) +AD4 394c595ee8c3 (+ACI-IB/srp: Move ib+AF8-destroy+AF8-cm+AF8-id() call into srp+AF8-free+AF8-ch+AF8-ib()+ACI) +AD4 509c07bc1850 (+ACI-IB/srp: Separate target and channel variables+ACI) +AD4 747fe000ef38 (+ACI-IB/srp: Introduce two new srp+AF8-target+AF8-port member variables+ACI) +AD4 77f2c1a40e6f (+ACI-IB/srp: Use block layer tags+ACI) +AD4 d92c0da71a35 (+ACI-IB/srp: Add multichannel support+ACI) +AD4 +AD4 +AD4 How should we proceed with this patch? Hi Sasha, Patch 2/2 does not have a +ACI-Cc: stable+ACI tag because it definitely should NOT be backported to older kernels. This patch only works for blk-mq which is fine with kernel v5.0. Older kernels however support both the legacy block layer and blk-mq. Bart.