From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C18EC282C0 for ; Thu, 24 Jan 2019 00:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1ABF4218A1 for ; Thu, 24 Jan 2019 00:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726322AbfAXADw (ORCPT ); Wed, 23 Jan 2019 19:03:52 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:35047 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAXADw (ORCPT ); Wed, 23 Jan 2019 19:03:52 -0500 Received: by mail-pf1-f195.google.com with SMTP id z9so2023361pfi.2; Wed, 23 Jan 2019 16:03:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=1+trg9/bgZ+CGlTdyuGVNr57d25KK+FS9Od8O4vBMRA=; b=b5waf69MEqKtE5JAO9Lk5lvw8Tg9NJv8qjQbr1tDpQUOaPYr0zUlFQkikVk+IKZ3gQ 9OYvi6cR0ceuf4dg8ZsjkykAYEncgrhj7t3mE8iidaPJUif5yeEjd0NSWA5KViPSuUnB HUN2Or49ldiU4Rz7Qdf+tCIfjyyKKPArrVFb96aNDc2IoAEEH6CMqkLI0PpSpvdfbGic MVzCRsrYQ1QNhfR/pyiyuXgrM2VvLAnon+/rQ6cvGRrOjz76FT0q9DhfXbPuVpjtoy4m uhvY6aMWefVbTP5emDKxNFT4FODXRODolEOlKMy8Z4iIWEv1FVyifJ+Hzt1K0eJigIO2 YalA== X-Gm-Message-State: AJcUukdOlV/qEs2WFw4smDiPOCLSC0JurJbZDmLWE6oFZaBhKWNDp3EV Udzqp0RpoKGpRpKf88DDnO4= X-Google-Smtp-Source: ALg8bN43xN6Ls6Tw6DVgulBQmL2CedV0IrNFEzj7OQiuZnOnbY1Fv1n55NlNwU9xeRWPFE95gzMsRQ== X-Received: by 2002:a63:2744:: with SMTP id n65mr3882898pgn.65.1548288230880; Wed, 23 Jan 2019 16:03:50 -0800 (PST) Received: from ?IPv6:2620:15c:2cd:203:5cdc:422c:7b28:ebb5? ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id t90sm28187092pfj.23.2019.01.23.16.03.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Jan 2019 16:03:50 -0800 (PST) Message-ID: <1548288228.9266.74.camel@acm.org> Subject: Re: [PATCH] Fix sense handling in __scsi_execute() From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Christoph Hellwig , Douglas Gilbert , stable@vger.kernel.org Date: Wed, 23 Jan 2019 16:03:48 -0800 In-Reply-To: <20190123224217.198935-1-bvanassche@acm.org> References: <20190123224217.198935-1-bvanassche@acm.org> Content-Type: text/plain; charset="UTF-7" X-Mailer: Evolution 3.26.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, 2019-01-23 at 14:42 -0800, Bart Van Assche wrote: +AD4 Since blk+AF8-execute+AF8-rq() no longer allocates a sense buffer and no longer +AD4 initializes the sense pointer the callers of blk+AF8-execute+AF8-rq() have to do +AD4 initialize the sense pointer. Hence this patch that initializes rq-+AD4-sense +AD4 and that removes a superfluous memcpy() statement. +AD4 +AD4 Cc: Christoph Hellwig +ADw-hch+AEA-lst.de+AD4 +AD4 Cc: Douglas Gilbert +ADw-dgilbert+AEA-interlog.com+AD4 +AD4 Cc: +ADw-stable+AEA-vger.kernel.org+AD4 +ACM v4.11+- +AD4 Fixes: 82ed4db499b8 (+ACI-block: split scsi+AF8-request out of struct request+ACI) +AD4 Signed-off-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 +AD4 --- +AD4 drivers/scsi/scsi+AF8-lib.c +AHw 3 +--- +AD4 1 file changed, 1 insertion(+-), 2 deletions(-) +AD4 +AD4 diff --git a/drivers/scsi/scsi+AF8-lib.c b/drivers/scsi/scsi+AF8-lib.c +AD4 index 4feba3b5aff1..8b9f4b1bca35 100644 +AD4 --- a/drivers/scsi/scsi+AF8-lib.c +AD4 +-+-+- b/drivers/scsi/scsi+AF8-lib.c +AD4 +AEAAQA -271,6 +-271,7 +AEAAQA int +AF8AXw-scsi+AF8-execute(struct scsi+AF8-device +ACo-sdev, const unsigned char +ACo-cmd, +AD4 rq-+AD4-cmd+AF8-len +AD0 COMMAND+AF8-SIZE(cmd+AFs-0+AF0)+ADs +AD4 memcpy(rq-+AD4-cmd, cmd, rq-+AD4-cmd+AF8-len)+ADs +AD4 rq-+AD4-retries +AD0 retries+ADs +AD4 +- rq-+AD4-sense +AD0 sense+ADs +AD4 req-+AD4-timeout +AD0 timeout+ADs +AD4 req-+AD4-cmd+AF8-flags +AHwAPQ flags+ADs +AD4 req-+AD4-rq+AF8-flags +AHwAPQ rq+AF8-flags +AHw RQF+AF8-QUIET+ADs +AD4 +AEAAQA -291,8 +-292,6 +AEAAQA int +AF8AXw-scsi+AF8-execute(struct scsi+AF8-device +ACo-sdev, const unsigned char +ACo-cmd, +AD4 +AD4 if (resid) +AD4 +ACo-resid +AD0 rq-+AD4-resid+AF8-len+ADs +AD4 - if (sense +ACYAJg rq-+AD4-sense+AF8-len) +AD4 - memcpy(sense, rq-+AD4-sense, SCSI+AF8-SENSE+AF8-BUFFERSIZE)+ADs +AD4 if (sshdr) +AD4 scsi+AF8-normalize+AF8-sense(rq-+AD4-sense, rq-+AD4-sense+AF8-len, sshdr)+ADs +AD4 ret +AD0 rq-+AD4-result+ADs Please ignore this patch - I just realized that this is not the right way to fix the issue I ran into. Bart.