From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B79C282C2 for ; Wed, 13 Feb 2019 13:53:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E3732075D for ; Wed, 13 Feb 2019 13:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550066014; bh=/GYP74aNPndK5f1YEy3XJ5V+H64aVgC7i1XTy7thWkQ=; h=Subject:To:Cc:From:Date:List-ID:From; b=0XCPOltVhuKfbXl65RpCurva2r2PY+bNMoh3IbOMBnoXxrLGmn9p4DqZHk5ohb0K9 1D6QiryQZpvGvCYprxvjmA9yjjn16X9giCJOoYCYI37vsb1vicOoEjWu/quGiR74YY pSK0wd+yBkjO/va+N5AlU79oaLXV+PXP7edgL2Js= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729677AbfBMNxd (ORCPT ); Wed, 13 Feb 2019 08:53:33 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:46551 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727452AbfBMNxd (ORCPT ); Wed, 13 Feb 2019 08:53:33 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 6723F33D9; Wed, 13 Feb 2019 08:53:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 13 Feb 2019 08:53:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=XkxOEY 6zZT2DwWUv7fSWfNHi2efDewMMNCaWpVpljCA=; b=t9KG7JQK34dqNnm2Zl4IaZ oL8yDSdDqSMj8GYMtzDfS8WD+Fa2aXGI9mvzKev6vX4PXQpJZoLJ1q7ClHVith62 Haq5ssECqESYb/jPbMwUn017B/xfcxnkOr2a1gniENObsq8koLDz8b5KFIyrdN3l 33M7u/FXdLq0M9v1h7njyEs+6yTx9LcPfDI+bXiFYW5Mk7PBtaFgS57nw6LSkntH pp+8/TtZFK3tdzjswQhy2xarZnXmoz+DI02TGhRgO1teVwZFgUDwxlI3rcq3/GQb u0Jxt3JQe1kdLTsg6P5cW+7avFOpmQoDa/QeoY1JKpRu7JeqctnrrGrbjlIq/9OQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledruddtfedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecunecujfgurhepuffvhfffkfggtgfgsehtkeertddttdflnecuhfhrohhmpeeogh hrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgqeenucfkphepkeefrdek iedrkeelrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh drtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id CF423E44A1; Wed, 13 Feb 2019 08:53:30 -0500 (EST) Subject: FAILED: patch "[PATCH] drm/amd/powerplay: Fix missing break in switch" failed to apply to 4.14-stable tree To: gustavo@embeddedor.com, alexander.deucher@amd.com Cc: From: Date: Wed, 13 Feb 2019 14:53:29 +0100 Message-ID: <155006600921225@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 2f10d823739680d2477ce34437e8a08a53117f40 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Fri, 25 Jan 2019 15:55:33 -0600 Subject: [PATCH] drm/amd/powerplay: Fix missing break in switch Add missing break statement in order to prevent the code from falling through to the default case. The resoning for this is that pclk_vol_table is an automatic variable. So, it makes no sense to update it just before falling through to the default case and return -EINVAL. This bug was found thanks to the ongoing efforts to enabling -Wimplicit-fallthrough. Fixes: cd70f3d6e3fa ("drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Alex Deucher diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c index f95c5f50eb0f..5273de3c5b98 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c @@ -1033,6 +1033,7 @@ static int smu10_get_clock_by_type_with_latency(struct pp_hwmgr *hwmgr, break; case amd_pp_dpp_clock: pclk_vol_table = pinfo->vdd_dep_on_dppclk; + break; default: return -EINVAL; }