From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C1F3C10F05 for ; Wed, 20 Mar 2019 15:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D0622183E for ; Wed, 20 Mar 2019 15:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553096257; bh=vFFOL1RBsoFiKaLlDmjUN7BjnaEbaTCQBd2UyaoAT3M=; h=Subject:To:Cc:From:Date:List-ID:From; b=GOwWy+tBlJwA5n2TUNrDUD69rbjeAZzm2OnseRqJH9TC5s7HIliKj5auPSKOJmqJK W9i0vZCMAJKCXV9CVaYObJDkvRPthHdCLC2+lPSa1Y+UOPhYFGizbJgYeGtTMqpFpP QxMv/DczeGU+Zo+SGvywzYUhMJrxJKpEgY9jx/Mw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbfCTPhh (ORCPT ); Wed, 20 Mar 2019 11:37:37 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43495 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbfCTPhg (ORCPT ); Wed, 20 Mar 2019 11:37:36 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5E15D2236B; Wed, 20 Mar 2019 11:37:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 20 Mar 2019 11:37:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YOlZsO 2jGE1wBTgzbf0TfVlznaiF9MKlLpsZxBPe0/s=; b=ZhKSg626XnhnQxMNfV94p/ 6zuVdLODdjEcYigeV6KtaAH0Z58sRdx0BY6xrDj6mE3oixoy6co+g8dmBzMtfD1Y LrhsoHBTuZ97wn0x0JotrcF51hL+lzqXGj7Yq7s4Tb6cjY6lo5Gwsj8B7mVV3Lz9 gNriFlKpgoiuI4tkaRTo0NaNEq6T0yIfoC2S8BlvX5Pw8GNZ4E58a/fyTSfwMG+8 /EyH/InFtLRkFt65lYCuQ5Lb5tKENjBpy14bELlnCz8IAW9rFEY1dAvy6V/t7GOo 5omKvBXXPjlnlvlubLYN8hcDimHDytfQlFt41HZpH8jRgGLtU3ceYyD/xOCqD3Vw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrieeigdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepuffvhfffkfggtgfgsehtkeertddttd flnecuhfhrohhmpeeoghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhg qeenucfkphepkeefrdekiedrkeelrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hgrhgvgheskhhrohgrhhdrtghomhenucevlhhushhtvghrufhiiigvpedv X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id CAC30E4980; Wed, 20 Mar 2019 11:37:34 -0400 (EDT) Subject: FAILED: patch "[PATCH] nfit/ars: Avoid stale ARS results" failed to apply to 4.14-stable tree To: dan.j.williams@intel.com, krzysztof.rusocki@intel.com, stable@vger.kernel.org, toshi.kani@hpe.com, vishal.l.verma@intel.com Cc: From: Date: Wed, 20 Mar 2019 16:37:23 +0100 Message-ID: <1553096243159205@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 78153dd45e7e0596ba32b15d02bda08e1513111e Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Wed, 13 Feb 2019 09:28:40 -0800 Subject: [PATCH] nfit/ars: Avoid stale ARS results Gate ARS result consumption on whether the OS issued start-ARS since the previous consumption. The BIOS may only clear its result buffers after a successful start-ARS. Fixes: 0caeef63e6d2 ("libnvdimm: Add a poison list and export badblocks") Cc: Reported-by: Krzysztof Rusocki Reported-by: Vishal Verma Reviewed-by: Toshi Kani Signed-off-by: Dan Williams diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 629cf91649d2..5c9eb8d700d3 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -2652,7 +2652,10 @@ static int ars_start(struct acpi_nfit_desc *acpi_desc, if (rc < 0) return rc; - return cmd_rc; + if (cmd_rc < 0) + return cmd_rc; + set_bit(ARS_VALID, &acpi_desc->scrub_flags); + return 0; } static int ars_continue(struct acpi_nfit_desc *acpi_desc) @@ -2745,6 +2748,17 @@ static int ars_status_process_records(struct acpi_nfit_desc *acpi_desc) */ if (ars_status->out_length < 44) return 0; + + /* + * Ignore potentially stale results that are only refreshed + * after a start-ARS event. + */ + if (!test_and_clear_bit(ARS_VALID, &acpi_desc->scrub_flags)) { + dev_dbg(acpi_desc->dev, "skip %d stale records\n", + ars_status->num_records); + return 0; + } + for (i = 0; i < ars_status->num_records; i++) { /* only process full records */ if (ars_status->out_length @@ -3229,6 +3243,7 @@ static int acpi_nfit_register_regions(struct acpi_nfit_desc *acpi_desc) struct nfit_spa *nfit_spa; int rc; + set_bit(ARS_VALID, &acpi_desc->scrub_flags); list_for_each_entry(nfit_spa, &acpi_desc->spas, list) { switch (nfit_spa_type(nfit_spa->spa)) { case NFIT_SPA_VOLATILE: diff --git a/drivers/acpi/nfit/nfit.h b/drivers/acpi/nfit/nfit.h index d14bad687fb8..0cbe5009eb2c 100644 --- a/drivers/acpi/nfit/nfit.h +++ b/drivers/acpi/nfit/nfit.h @@ -213,6 +213,7 @@ struct nfit_mem { enum scrub_flags { ARS_BUSY, ARS_CANCEL, + ARS_VALID, ARS_POLL, };