From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57215C43381 for ; Wed, 20 Mar 2019 19:55:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A66320857 for ; Wed, 20 Mar 2019 19:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553111716; bh=CrR0avDHN++tcy1J31R4D2gKhlFR7Hg6ydeJx8Ud1f4=; h=Subject:To:Cc:From:Date:List-ID:From; b=h72td/DmiLRTKECrHFjTksjkvF3YCNGSCFQgKLWY6fwGpEfdFmwXuhCLlH70oAS+X 1QE9gF7qS4jqi5ExKPUco7jD19hJmAfkGpOgsFBiBgNCaz04RnGiXoSYvy1nVQGY8C C/xahXQ6Ym26m9pIRJbIYzQTwRDR4ls9eJRTYgmM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726123AbfCTTzP (ORCPT ); Wed, 20 Mar 2019 15:55:15 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:42471 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbfCTTzP (ORCPT ); Wed, 20 Mar 2019 15:55:15 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7B5F6231CA; Wed, 20 Mar 2019 15:55:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 20 Mar 2019 15:55:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=utM0Rv qnuNEhJ07Oq0TdQzuISwOUaRJcIGdzfExAtMk=; b=yMh0iB/IAubt42aHKILsek LSf0E/+73Af1VK1I/c9FnWkojfHVr0xa8QwpVuyy+YITEAxpgH8bZNlkiyGza9aN JtfZfxRBtaSaKPae9KICgTke6hRq2AFqopVoy30n+OsAfXtrNXuQnDgozddxacz7 OPimwV+wY96vcVECnG5RXBLVNbsE4mkJPiBDIfayNYF7G7bIQvh0qA6D564VUlHA wOzsMVXpR0V9oPctG82NcSDFv9b/yEXFomCDY+jKyWYRIKznhqq9i5UbQPBiXlZk PoQW74RY3bsYTB/5v2UAR2UdWqw3+g9KHLygwpDmfa7VqHNkcO7ZN4la5IUKGJQw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrieeigddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecukfhppeekfedrkeeirdekledruddtjeenucfrrghrrghmpehmrghilhhfrhhomh epghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgepud X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id DFDC3E4360; Wed, 20 Mar 2019 15:55:13 -0400 (EDT) Subject: FAILED: patch "[PATCH] PCI: qcom: Don't deassert reset GPIO during probe" failed to apply to 4.14-stable tree To: bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com, svarbanov@mm-sol.com Cc: From: Date: Wed, 20 Mar 2019 20:55:03 +0100 Message-ID: <15531117031871@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 02b485e31d98265189b91f3e69c43df2ed50610c Mon Sep 17 00:00:00 2001 From: Bjorn Andersson Date: Fri, 25 Jan 2019 15:26:16 -0800 Subject: [PATCH] PCI: qcom: Don't deassert reset GPIO during probe Acquiring the reset GPIO low means that reset is being deasserted, this is followed almost immediately with qcom_pcie_host_init() asserting it, initializing it and then finally deasserting it again, for the link to come up. Some PCIe devices requires a minimum time between the initial deassert and subsequent reset cycles. In a platform that boots with the reset GPIO asserted this requirement is being violated by this deassert/assert pulse. Acquire the reset GPIO high to prevent this situation by matching the state to the subsequent asserted state. Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") Signed-off-by: Bjorn Andersson [lorenzo.pieralisi@arm.com: updated commit log] Signed-off-by: Lorenzo Pieralisi Acked-by: Stanimir Varbanov Cc: stable@vger.kernel.org diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index d185ea5fe996..a7f703556790 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1228,7 +1228,7 @@ static int qcom_pcie_probe(struct platform_device *pdev) pcie->ops = of_device_get_match_data(dev); - pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_LOW); + pcie->reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_HIGH); if (IS_ERR(pcie->reset)) { ret = PTR_ERR(pcie->reset); goto err_pm_runtime_put;