From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8DB1C04AB4 for ; Fri, 17 May 2019 12:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BA06204FD for ; Fri, 17 May 2019 12:23:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558095780; bh=ZokXORGxGpZbpRB4bPKrua3XJUNwqDG9Epwyakwh5wE=; h=Subject:To:Cc:From:Date:List-ID:From; b=F/L52bIKCq/zExfD1VD/4jNFh9HJK8Tl5SjltTBY0P96RqAaofVFLXaEsbrUzAZhY 9wPSAABH/5ygPC2kueB7jVHvGDm42I7JgjA+aNb/o6SJQ75xf+pXlZMU0fMRflvXd1 fgA+1pfl9yZotraEkE00TzMCtSegK9QU7+TpbSgE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728520AbfEQMXA (ORCPT ); Fri, 17 May 2019 08:23:00 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:46329 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728193AbfEQMXA (ORCPT ); Fri, 17 May 2019 08:23:00 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D17C446A; Fri, 17 May 2019 08:22:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 17 May 2019 08:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=z+wB8B o2eWDfx31fxNFlyYOC8Lx7NuTIzNpQvy3rcHw=; b=qOVYWccRIm0iQXuB68p9ml qoS8BqmnFLYKHddZDZRkzPUlK30XQaj5+d95qCIrhIslRjcUoEYecFb7S2O0n9cN /ieejgl7voI0JEle/o2dmZtvSCgEjwbisB1IjOS2Jq9U7f+ZtIPJx9Ifx4BCRSDY /Toyv7sEnVvuAs2WO4HV2Qp+tM5Vyrcf+rC2kLb2bVNieJTGll7qwcEXQ8onLMXi 1HPP6+8mkIqGjdpNrYGrTzxWK9mBRhT/BGolV0hXE1/PwZXjgPTUqM2a4FFcZqYW RdN2YKh9OrREConYSX4G3iV3MVNB69lyFok2IljQL/Y1PPS9lOwNkOdgdBSwaMSQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddtvddghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecukfhppeekfedrkeeirdekledruddtjeenucfrrghrrghmpehmrghilhhfrhhomh epghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgepvd X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 7ABF58005B; Fri, 17 May 2019 08:22:57 -0400 (EDT) Subject: FAILED: patch "[PATCH] power: supply: axp288_charger: Fix unchecked return value" failed to apply to 4.4-stable tree To: gustavo@embeddedor.com, hdegoede@redhat.com, sebastian.reichel@collabora.com Cc: From: Date: Fri, 17 May 2019 14:22:55 +0200 Message-ID: <1558095775165218@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From c3422ad5f84a66739ec6a37251ca27638c85b6be Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Mon, 18 Mar 2019 11:14:39 -0500 Subject: [PATCH] power: supply: axp288_charger: Fix unchecked return value Currently there is no check on platform_get_irq() return value in case it fails, hence never actually reporting any errors and causing unexpected behavior when using such value as argument for function regmap_irq_get_virq(). Fix this by adding a proper check, a message reporting any errors and returning *pirq* Addresses-Coverity-ID: 1443940 ("Improper use of negative value") Fixes: 843735b788a4 ("power: axp288_charger: axp288 charger driver") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Reviewed-by: Hans de Goede Signed-off-by: Sebastian Reichel diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c index f8c6da9277b3..00b961890a38 100644 --- a/drivers/power/supply/axp288_charger.c +++ b/drivers/power/supply/axp288_charger.c @@ -833,6 +833,10 @@ static int axp288_charger_probe(struct platform_device *pdev) /* Register charger interrupts */ for (i = 0; i < CHRG_INTR_END; i++) { pirq = platform_get_irq(info->pdev, i); + if (pirq < 0) { + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", pirq); + return pirq; + } info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq); if (info->irq[i] < 0) { dev_warn(&info->pdev->dev,