stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Michal Hocko <mhocko@kernel.org>, Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, aarcange@redhat.com,
	akpm@linux-foundation.org, jannh@google.com, jgg@mellanox.com,
	oleg@redhat.com, peterx@redhat.com, rppt@linux.ibm.com,
	torvalds@linux-foundation.org, stable-commits@vger.kernel.org
Subject: Re: Patch "coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping" has been added to the 4.4-stable tree
Date: Wed, 05 Jun 2019 13:08:48 +0100	[thread overview]
Message-ID: <1559736528.24330.87.camel@codethink.co.uk> (raw)
In-Reply-To: <20190605065024.GA15685@dhcp22.suse.cz>

On Wed, 2019-06-05 at 08:50 +0200, Michal Hocko wrote:
> On Tue 04-06-19 16:51:38, Ben Hutchings wrote:
> [...]
> > - I don't understand why collapse_huge_range() needs to be fixed, but
> > then I really don't understand the khugepaged code at all!  So I would
> > trust Michal on this.
> 
> To be honest, I am not really sure myself here. But we are using a
> remote mm there and I do not see anything that would prevent from racing
> with exit/coredump. Maybe I am wrong. Let's wait for Andrea for his
> review feedback. This patch is quite tricky for the stable backport.

So, Greg, it seems like you should drop this from the current stable
round.

Ben.

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom

  reply	other threads:[~2019-06-05 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <155965961313615@kroah.com>
     [not found] ` <20190604145216.GJ4669@dhcp22.suse.cz>
2019-06-04 15:07   ` Patch "coredump: fix race condition between mmget_not_zero()/get_task_mm() and core dumping" has been added to the 4.4-stable tree Greg KH
2019-06-04 15:51     ` Ben Hutchings
2019-06-05  6:50       ` Michal Hocko
2019-06-05 12:08         ` Ben Hutchings [this message]
2019-06-06 15:34           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1559736528.24330.87.camel@codethink.co.uk \
    --to=ben.hutchings@codethink.co.uk \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jannh@google.com \
    --cc=jgg@mellanox.com \
    --cc=mhocko@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterx@redhat.com \
    --cc=rppt@linux.ibm.com \
    --cc=stable-commits@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).