Re: Patch "clk: jz4740: Add TCU clock" has been added to the 4.4-stable tree

Re: Patch "clk: jz4740: Add TCU clock" has been added to the 4.4-stable tree

[Paul Cercueil]

Hi Sasha,

I think this patch shouldn't be added to the stable trees; it will 
cause the TCU clock to be managed by the clock framework and 
automatically gated after bootup since it has no client, causing a 
global system lockup. It's only really applicable to 5.3.

Thanks,
-Paul



Le sam., oct. 5, 2019 at 19:56, Sasha Levin <sashal@kernel.org> a 
écrit :
> This is a note to let you know that I've just added the patch titled
> 
>     clk: jz4740: Add TCU clock
> 
> to the 4.4-stable tree which can be found at:
>     
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      clk-jz4740-add-tcu-clock.patch
> and it can be found in the queue-4.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable 
> tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit c72b7e327a8b4d3b870f76011f674134f9ac38f6
> Author: Paul Cercueil <paul@crapouillou.net>
> Date:   Wed Jul 24 13:16:10 2019 -0400
> 
>     clk: jz4740: Add TCU clock
> 
>     [ Upstream commit 73dd11dc1a883d4c994d729dc9984f4890001157 ]
> 
>     Add the missing TCU clock to the list of clocks supplied by the 
> CGU for
>     the JZ4740 SoC.
> 
>     Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>     Tested-by: Mathieu Malaterre <malat@debian.org>
>     Tested-by: Artur Rojek <contact@artur-rojek.eu>
>     Acked-by: Stephen Boyd <sboyd@kernel.org>
>     Acked-by: Rob Herring <robh@kernel.org>
>     Signed-off-by: Paul Burton <paul.burton@mips.com>
>     Cc: Ralf Baechle <ralf@linux-mips.org>
>     Cc: James Hogan <jhogan@kernel.org>
>     Cc: Jonathan Corbet <corbet@lwn.net>
>     Cc: Lee Jones <lee.jones@linaro.org>
>     Cc: Arnd Bergmann <arnd@arndb.de>
>     Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>     Cc: Thomas Gleixner <tglx@linutronix.de>
>     Cc: Michael Turquette <mturquette@baylibre.com>
>     Cc: Jason Cooper <jason@lakedaemon.net>
>     Cc: Marc Zyngier <marc.zyngier@arm.com>
>     Cc: Rob Herring <robh+dt@kernel.org>
>     Cc: Mark Rutland <mark.rutland@arm.com>
>     Cc: devicetree@vger.kernel.org
>     Cc: linux-kernel@vger.kernel.org
>     Cc: linux-doc@vger.kernel.org
>     Cc: linux-mips@vger.kernel.org
>     Cc: linux-clk@vger.kernel.org
>     Cc: od@zcrc.me
>     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> diff --git a/drivers/clk/ingenic/jz4740-cgu.c 
> b/drivers/clk/ingenic/jz4740-cgu.c
> index 305a26c2a800e..01b5b8b103888 100644
> --- a/drivers/clk/ingenic/jz4740-cgu.c
> +++ b/drivers/clk/ingenic/jz4740-cgu.c
> @@ -211,6 +211,12 @@ static const struct ingenic_cgu_clk_info 
> jz4740_cgu_clocks[] = {
>  		.parents = { JZ4740_CLK_EXT, -1, -1, -1 },
>  		.gate = { CGU_REG_CLKGR, 5 },
>  	},
> +
> +	[JZ4740_CLK_TCU] = {
> +		"tcu", CGU_CLK_GATE,
> +		.parents = { JZ4740_CLK_EXT, -1, -1, -1 },
> +		.gate = { CGU_REG_CLKGR, 1 },
> +	},
>  };
> 
>  static void __init jz4740_cgu_init(struct device_node *np)
> diff --git a/include/dt-bindings/clock/jz4740-cgu.h 
> b/include/dt-bindings/clock/jz4740-cgu.h
> index 43153d3e9bd26..ff7c27bc98e37 100644
> --- a/include/dt-bindings/clock/jz4740-cgu.h
> +++ b/include/dt-bindings/clock/jz4740-cgu.h
> @@ -33,5 +33,6 @@
>  #define JZ4740_CLK_ADC		19
>  #define JZ4740_CLK_I2C		20
>  #define JZ4740_CLK_AIC		21
> +#define JZ4740_CLK_TCU		22
> 
>  #endif /* __DT_BINDINGS_CLOCK_JZ4740_CGU_H__ */

Re: Patch "clk: jz4740: Add TCU clock" has been added to the 4.4-stable tree

[Greg KH]

On Sun, Oct 06, 2019 at 02:09:15AM +0200, Paul Cercueil wrote:
> Hi Sasha,
> 
> I think this patch shouldn't be added to the stable trees; it will cause the
> TCU clock to be managed by the clock framework and automatically gated after
> bootup since it has no client, causing a global system lockup. It's only
> really applicable to 5.3.

Now dropped from everywhere, thanks!

greg k-h