* FAILED: patch "[PATCH] serial: sprd: Add clearing break interrupt operation" failed to apply to 4.19-stable tree
@ 2019-12-29 15:46 gregkh
2020-01-02 0:57 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: gregkh @ 2019-12-29 15:46 UTC (permalink / raw)
To: yonghan.ye, baolin.wang7, gregkh, stable; +Cc: stable
The patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From abeb2e9414d7e3a0d8417bc3b13d7172513ea8a0 Mon Sep 17 00:00:00 2001
From: Yonghan Ye <yonghan.ye@unisoc.com>
Date: Wed, 4 Dec 2019 20:00:07 +0800
Subject: [PATCH] serial: sprd: Add clearing break interrupt operation
A break interrupt will be generated if the RX line was pulled low, which
means some abnomal behaviors occurred of the UART. In this case, we still
need to clear this break interrupt status, otherwise it will cause irq
storm to crash the whole system.
Fixes: b7396a38fb28 ("tty/serial: Add Spreadtrum sc9836-uart driver support")
Signed-off-by: Yonghan Ye <yonghan.ye@unisoc.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Link: https://lore.kernel.org/r/925e51b73099c90158e080b8f5bed9b3b38c4548.1575460601.git.baolin.wang7@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
index 31df23502562..f60a59d9bf27 100644
--- a/drivers/tty/serial/sprd_serial.c
+++ b/drivers/tty/serial/sprd_serial.c
@@ -679,6 +679,9 @@ static irqreturn_t sprd_handle_irq(int irq, void *dev_id)
if (ims & SPRD_IMSR_TIMEOUT)
serial_out(port, SPRD_ICLR, SPRD_ICLR_TIMEOUT);
+ if (ims & SPRD_IMSR_BREAK_DETECT)
+ serial_out(port, SPRD_ICLR, SPRD_IMSR_BREAK_DETECT);
+
if (ims & (SPRD_IMSR_RX_FIFO_FULL | SPRD_IMSR_BREAK_DETECT |
SPRD_IMSR_TIMEOUT))
sprd_rx(port);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: FAILED: patch "[PATCH] serial: sprd: Add clearing break interrupt operation" failed to apply to 4.19-stable tree
2019-12-29 15:46 FAILED: patch "[PATCH] serial: sprd: Add clearing break interrupt operation" failed to apply to 4.19-stable tree gregkh
@ 2020-01-02 0:57 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2020-01-02 0:57 UTC (permalink / raw)
To: gregkh; +Cc: yonghan.ye, baolin.wang7, stable
On Sun, Dec 29, 2019 at 04:46:28PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From abeb2e9414d7e3a0d8417bc3b13d7172513ea8a0 Mon Sep 17 00:00:00 2001
>From: Yonghan Ye <yonghan.ye@unisoc.com>
>Date: Wed, 4 Dec 2019 20:00:07 +0800
>Subject: [PATCH] serial: sprd: Add clearing break interrupt operation
>
>A break interrupt will be generated if the RX line was pulled low, which
>means some abnomal behaviors occurred of the UART. In this case, we still
>need to clear this break interrupt status, otherwise it will cause irq
>storm to crash the whole system.
>
>Fixes: b7396a38fb28 ("tty/serial: Add Spreadtrum sc9836-uart driver support")
>Signed-off-by: Yonghan Ye <yonghan.ye@unisoc.com>
>Cc: stable <stable@vger.kernel.org>
>Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
>Link: https://lore.kernel.org/r/925e51b73099c90158e080b8f5bed9b3b38c4548.1575460601.git.baolin.wang7@gmail.com
>Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Context conflicts due to indentation fixes in the file, fixed up and
queued up for all branches.
--
Thanks,
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-02 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-29 15:46 FAILED: patch "[PATCH] serial: sprd: Add clearing break interrupt operation" failed to apply to 4.19-stable tree gregkh
2020-01-02 0:57 ` Sasha Levin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).