From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75582C352A5 for ; Mon, 10 Feb 2020 18:32:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 403BF20863 for ; Mon, 10 Feb 2020 18:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581359566; bh=I/VVz2zwYtW+yV89KNPCrFXp5DRMAdCgt0LYcipqgw8=; h=Subject:To:From:Date:List-ID:From; b=lCTpa9N1Myg5h15SbwL4bB7uGbhkaI/H9k2uotnZcl3bKOZ1ee3AAJte+DKk2JzUf JFpzANx4ksBbBUsGsn8EYWUXzJwudEgcFSDRlKaj5mNO961DZj25U+GafGSriKtFXu xQyHbn6Cxo4DoIkA0nsq2s24Jg8u2yCr2/J7OmPs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727613AbgBJScp (ORCPT ); Mon, 10 Feb 2020 13:32:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:51224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726831AbgBJScp (ORCPT ); Mon, 10 Feb 2020 13:32:45 -0500 Received: from localhost (unknown [104.132.1.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5B402085B; Mon, 10 Feb 2020 18:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581359565; bh=I/VVz2zwYtW+yV89KNPCrFXp5DRMAdCgt0LYcipqgw8=; h=Subject:To:From:Date:From; b=ScLYx2DBdb3r6rhK/1IH7uNjszlS6b7KPJttsRpnJ2rdaNGAYhMC7W5DYFDiKbAvh 5VE0Q1kOA6TBjfH+3jOCZqJkxKpMyDdGrycy+VREzSg2yNfY83/bsGPfttI7xeF9SU q+UT/OPXxSoRV9tt17qIBP+NF9VdbAD6+VdpcO9Q= Subject: patch "staging: rtl8188eu: Fix potential overuse of kernel memory" added to staging-linus To: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, pietroliva@gmail.com, stable@vger.kernel.org From: Date: Mon, 10 Feb 2020 10:32:44 -0800 Message-ID: <158135956458144@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is a note to let you know that I've just added the patch titled staging: rtl8188eu: Fix potential overuse of kernel memory to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 4ddf8ab8d15ddbc52eefb44eb64e38466ce1f70f Mon Sep 17 00:00:00 2001 From: Larry Finger Date: Mon, 10 Feb 2020 12:02:32 -0600 Subject: staging: rtl8188eu: Fix potential overuse of kernel memory In routine wpa_supplicant_ioctl(), the user-controlled p->length is checked to be at least the size of struct ieee_param size, but the code does not detect the case where p->length is greater than the size of the struct, thus a malicious user could be wasting kernel memory. Fixes commit a2c60d42d97c ("Add files for new driver - part 16"). Reported by: Pietro Oliva Cc: Pietro Oliva Cc: Stable Fixes commit a2c60d42d97c ("Add files for new driver - part 16"). Signed-off-by: Larry Finger Link: https://lore.kernel.org/r/20200210180235.21691-4-Larry.Finger@lwfinger.net Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c index 7d21f5799640..acca3ae8b254 100644 --- a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c @@ -2009,7 +2009,7 @@ static int wpa_supplicant_ioctl(struct net_device *dev, struct iw_point *p) struct ieee_param *param; uint ret = 0; - if (p->length < sizeof(struct ieee_param) || !p->pointer) { + if (!p->pointer || p->length != sizeof(struct ieee_param)) { ret = -EINVAL; goto out; } -- 2.25.0