From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F8FC3F2CD for ; Thu, 5 Mar 2020 15:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 782E32070E for ; Thu, 5 Mar 2020 15:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583421513; bh=fqQ46PXm4WvMNC7v+D/rKNKV58ebLmFlgE1rS5hFuUA=; h=Subject:To:From:Date:List-ID:From; b=EnRhnXxo2/q+FhxjO0a+ylAgegH6dwaaEdGvkrJy/jkMUsaOpkzl7pDkBomkpG1nn IFcaejYQ/b5uwuEPayGu/Aau9f63dlH2tHJfvNpdgevOZkmugH+qgfRD4tHJp88u0U wHXsOIJo3/G9ShvwgQmhAAbD+WTODPvtJKUsEwog= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbgCEPSc (ORCPT ); Thu, 5 Mar 2020 10:18:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:51730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbgCEPSc (ORCPT ); Thu, 5 Mar 2020 10:18:32 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C6034208CD; Thu, 5 Mar 2020 15:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583421512; bh=fqQ46PXm4WvMNC7v+D/rKNKV58ebLmFlgE1rS5hFuUA=; h=Subject:To:From:Date:From; b=YUo0gOAZcmMx/smoHxNIChWbmyaV9chUkpiDMOn21tQgvwKpmNXV/o0BPAO+CHY5Y M2C6MQGVKU/i98vvOI5nfw5uFguDuafSkjDAAVqoVocx+G5Lk/MwjJoj6Vikbxuogd ueFgWWJW9Mm3KmB0E0RjcWqO5Gc/uhUpI9OqVHkU= Subject: patch "staging: kpc2000: prevent underflow in cpld_reconfigure()" added to staging-next To: dan.carpenter@oracle.com, gregkh@linuxfoundation.org, stable@vger.kernel.org From: Date: Thu, 05 Mar 2020 16:18:17 +0100 Message-ID: <158342149718094@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is a note to let you know that I've just added the patch titled staging: kpc2000: prevent underflow in cpld_reconfigure() to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the staging-next branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will also be merged in the next major kernel release during the merge window. If you have any questions about this process, please let me know. >From 72db61d7d17a475d3cc9de1a7c871d518fcd82f0 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 24 Feb 2020 13:33:25 +0300 Subject: staging: kpc2000: prevent underflow in cpld_reconfigure() This function should not allow negative values of "wr_val". If negatives are allowed then capping the upper bound at 7 is meaningless. Let's make it unsigned. Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by: Dan Carpenter Cc: stable Link: https://lore.kernel.org/r/20200224103325.hrxdnaeqsthplu42@kili.mountain Signed-off-by: Greg Kroah-Hartman --- drivers/staging/kpc2000/kpc2000/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/core.c b/drivers/staging/kpc2000/kpc2000/core.c index 93cf28febdf6..7b00d7069e21 100644 --- a/drivers/staging/kpc2000/kpc2000/core.c +++ b/drivers/staging/kpc2000/kpc2000/core.c @@ -110,10 +110,10 @@ static ssize_t cpld_reconfigure(struct device *dev, const char *buf, size_t count) { struct kp2000_device *pcard = dev_get_drvdata(dev); - long wr_val; + unsigned long wr_val; int rv; - rv = kstrtol(buf, 0, &wr_val); + rv = kstrtoul(buf, 0, &wr_val); if (rv < 0) return rv; if (wr_val > 7) -- 2.25.1