From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 785ABC0044D for ; Mon, 16 Mar 2020 12:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C31F205ED for ; Mon, 16 Mar 2020 12:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584363459; bh=02KGsCD2Om+bXg+LNTzxI6p7b970XkJn0dIlHDI7Gic=; h=Subject:To:Cc:From:Date:List-ID:From; b=bfCl+EsJkklkmX2o9vcexEGqR1LXVecMsVP9wJynbOS60kEs+qWmQ1WE398DfbP94 HQ2gS39thGfv9HL+B+ZtDZzhJSRB3m4JBfM+9z43jmLVEJp5aH0IFgRPwj5WWVr44W lEUKyvnJ0Vd0RrM+OEuyfxroMukw8JuX43BSSaks= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730924AbgCPM5j (ORCPT ); Mon, 16 Mar 2020 08:57:39 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:35005 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730896AbgCPM5i (ORCPT ); Mon, 16 Mar 2020 08:57:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D24F2871; Mon, 16 Mar 2020 08:57:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 16 Mar 2020 08:57:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=SS/bKD 2MScv/5KQ/LWVfn0V94Xu2rNV28SdDcGnQ5hs=; b=AmGdSoNiKwkvaW8F7vm5+V SDo7J0RKygrYfXmZEcCEPhRINUxcCrmX0f+Iladd01jXiNkrIwpinbkscrAXxjQl FiMQ3S8bk9XDpuEezUvczb7EnXyF+nlllbXI/vgC5dFMSfaGleSU4CNgw+g8n5u/ u6m+yU0LeNiw1dEIFIVpseDY/1AzwIqgKS7thI7k8WDqas8OJnSsT6lTEFItDq7L aVTkPwH5VuEnEgE23/COjt9z3t74eswjhAm1sQvGZiRkPWcHhWA+HUg23suPABqV Nio05vkeSbRmUclbwVJ+8a6Y9N5qOaQd/IFjVZIVY3LVkQGEtlpnmgruEz1unWeA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeffedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefuvffhfffkgggtgfesthekredttd dtlfenucfhrhhomhepoehgrhgvghhkhheslhhinhhugihfohhunhgurghtihhonhdrohhr gheqnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepkeefrdekiedrkeelrd dutdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep ghhrvghgsehkrhhorghhrdgtohhm X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 18B3B3061856; Mon, 16 Mar 2020 08:57:37 -0400 (EDT) Subject: FAILED: patch "[PATCH] efi: Add a sanity check to efivar_store_raw()" failed to apply to 4.14-stable tree To: vdronov@redhat.com, ardb@kernel.org, mingo@kernel.org, stable@vger.kernel.org Cc: From: Date: Mon, 16 Mar 2020 13:57:26 +0100 Message-ID: <1584363446211133@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From d6c066fda90d578aacdf19771a027ed484a79825 Mon Sep 17 00:00:00 2001 From: Vladis Dronov Date: Sun, 8 Mar 2020 09:08:55 +0100 Subject: [PATCH] efi: Add a sanity check to efivar_store_raw() Add a sanity check to efivar_store_raw() the same way efivar_{attr,size,data}_read() and efivar_show_raw() have it. Signed-off-by: Vladis Dronov Signed-off-by: Ard Biesheuvel Signed-off-by: Ingo Molnar Cc: Link: https://lore.kernel.org/r/20200305084041.24053-3-vdronov@redhat.com Link: https://lore.kernel.org/r/20200308080859.21568-25-ardb@kernel.org diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c index 69f13bc4b931..aff3dfb4d7ba 100644 --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -208,6 +208,9 @@ efivar_store_raw(struct efivar_entry *entry, const char *buf, size_t count) u8 *data; int err; + if (!entry || !buf) + return -EINVAL; + if (in_compat_syscall()) { struct compat_efi_variable *compat;