From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C1F5C54FCB for ; Thu, 23 Apr 2020 13:50:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1E522077D for ; Thu, 23 Apr 2020 13:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587649843; bh=gWV9h4/89SiltEXNq2LsJUeDhLBLUKrRfCsELWeJaVc=; h=Subject:To:From:Date:List-ID:From; b=CYq/kDZS2apLoTPLT6OK/EKJVdAthnzDQVMknSeyWQUP0DXXM2cx/fBT/0B6mDkbY 45O6423K2RrRIhGvyqZRAj0GsI72sVNqRIB+NJ31EAWOinM40EvrFdkO4ZbCN99Ax6 2mBv3doR07qJLTgpnY61C11AdGwr3qEXChS+D6JQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728625AbgDWNun (ORCPT ); Thu, 23 Apr 2020 09:50:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:39424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726926AbgDWNun (ORCPT ); Thu, 23 Apr 2020 09:50:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47E1C2076C; Thu, 23 Apr 2020 13:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587649842; bh=gWV9h4/89SiltEXNq2LsJUeDhLBLUKrRfCsELWeJaVc=; h=Subject:To:From:Date:From; b=maqGfvtpZPgTXxu/UldTGCL4bc6wNgz7RnXwlEHPbBenYyOJIGJWJD0sIeBZ2opFZ z0FJfYMKhkQ3z2WIAZomg6Qm+wdtwEx7Zq18xIRtQxsaTQzenvN09WWzYsrUcbuT3B vv+05naYrN/bqoSheZ91SfLIOePTIwJsQriMwyLA= Subject: patch "tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart" added to tty-linus To: zou_wei@huawei.com, gregkh@linuxfoundation.org, hulkci@huawei.com, stable@vger.kernel.org From: Date: Thu, 23 Apr 2020 15:50:40 +0200 Message-ID: <1587649840131116@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org This is a note to let you know that I've just added the patch titled tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-linus branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. >From 580d952e44de5509c69c8f9346180ecaa78ebeec Mon Sep 17 00:00:00 2001 From: Zou Wei Date: Tue, 21 Apr 2020 20:31:46 +0800 Subject: tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart This patch fixes below error reported by coccicheck drivers/tty/serial/bcm63xx_uart.c:848:2-8: ERROR: missing clk_put; clk_get on line 842 and execution via conditional on line 846 Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/") Reported-by: Hulk Robot Signed-off-by: Zou Wei Cc: stable Link: https://lore.kernel.org/r/1587472306-105155-1-git-send-email-zou_wei@huawei.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/bcm63xx_uart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/bcm63xx_uart.c b/drivers/tty/serial/bcm63xx_uart.c index 5674da2b76f0..ed0aa5c0d9b7 100644 --- a/drivers/tty/serial/bcm63xx_uart.c +++ b/drivers/tty/serial/bcm63xx_uart.c @@ -843,8 +843,10 @@ static int bcm_uart_probe(struct platform_device *pdev) if (IS_ERR(clk) && pdev->dev.of_node) clk = of_clk_get(pdev->dev.of_node, 0); - if (IS_ERR(clk)) + if (IS_ERR(clk)) { + clk_put(clk); return -ENODEV; + } port->iotype = UPIO_MEM; port->irq = res_irq->start; -- 2.26.2