From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D53C10F0B for ; Thu, 18 Apr 2019 08:33:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9FF220821 for ; Thu, 18 Apr 2019 08:33:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733205AbfDRIdG (ORCPT ); Thu, 18 Apr 2019 04:33:06 -0400 Received: from gloria.sntech.de ([185.11.138.130]:58786 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbfDRIdG (ORCPT ); Thu, 18 Apr 2019 04:33:06 -0400 Received: from wf0380.dip.tu-dresden.de ([141.76.181.124] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hH2TV-0002Kh-Uq; Thu, 18 Apr 2019 10:32:53 +0200 From: Heiko Stuebner To: hjc@rock-chips.com Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Vicente Bergas , Jeffy Chen , Robin Murphy , Marc Zyngier , Brian Norris , Doug Anderson , stable@vger.kernel.org Subject: Re: [PATCH v2] drm/rockchip: shutdown drm subsystem on shutdown Date: Thu, 18 Apr 2019 10:32:52 +0200 Message-ID: <16214989.ofMSVjYgR7@phil> In-Reply-To: <20190402113753.10118-1-heiko@sntech.de> References: <20190402113753.10118-1-heiko@sntech.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Am Dienstag, 2. April 2019, 13:37:53 CEST schrieb Heiko Stuebner: > From: Vicente Bergas > > As explained by Robin Murphy: > > the IOMMU shutdown disables paging, so if the VOP is still > > scanning out then that will result in whatever IOVAs it was using now going > > straight out onto the bus as physical addresses. > > We had a more radical approach before in commit > 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on reboot/kexec") > but that resulted in new warnings and oopses on shutdown on rk3399 > chromeos devices. > > So second try is resurrecting Vicentes shutdown change which should > achieve the same result but in a less drastic way. > > Fixes: 63238173b2fa ("Revert drm/rockchip: Allow driver to be shutdown on reboot/kexec") > Cc: Jeffy Chen > Cc: Robin Murphy > Cc: Marc Zyngier > Cc: Brian Norris > Cc: Doug Anderson > Cc: stable@vger.kernel.org > Suggested-by: JeffyChen > Suggested-by: Robin Murphy > Signed-off-by: Vicente Bergas > [adapted commit message to explain the history] > Signed-off-by: Heiko Stuebner applied to drm-misc-next Not fixes, to give it more exposure this time. It still has a stable tag so should nevertheless trickle down to stable in time as well. Thanks for all the testing Heiko