From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout3.samsung.com ([203.254.224.33]:32485 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbeB0PZI (ORCPT ); Tue, 27 Feb 2018 10:25:08 -0500 From: Bartlomiej Zolnierkiewicz To: Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski , Eduardo Valentin , Zhang Rui Subject: Re: [PATCH] thermal: exynos: Propagate error value from tmu_read() Date: Tue, 27 Feb 2018 16:25:02 +0100 Message-id: <1635777.KPLQ7M4AcC@amdc3058> In-reply-to: <20180227151405.9618-1-m.szyprowski@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" References: <20180227151405.9618-1-m.szyprowski@samsung.com> Sender: stable-owner@vger.kernel.org List-ID: On Tuesday, February 27, 2018 04:14:05 PM Marek Szyprowski wrote: > tmu_read() in case of Exynos4210 might return error for out of bound > values. Current code ignores such value, what leads to reporting critical > temperature value. Add proper error code propagation to exynos_get_temp() > function. > > Signed-off-by: Marek Szyprowski > CC: stable@vger.kernel.org # v4.6+ Thanks for fixing this. Acked-by: Bartlomiej Zolnierkiewicz > --- > This patch is prepared on top of "thermal: exynos: Reading temperature > makes sense only when TMU is turned on" patch. Both are required > to finally fix thermal support on Exynos4210 based boards. > > This patch only applies cleanly together with the mentioned "thermal: > exynos: Reading temperature makes sense only when TMU is turned on" > patch on v4.6+ kernels. You may also add: Fixes: 3b6a1a805f34 ("thermal: samsung: core: Exynos TMU rework to use device tree for configuration") to the patch description. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics