From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from gloria.sntech.de ([95.129.55.99]:49732 "EHLO gloria.sntech.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S964845AbeFRIUA (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 18 Jun 2018 04:20:00 -0400
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: dri-devel@lists.freedesktop.org,
        linux-rockchip@lists.infradead.org, ezequiel@collabora.com,
        tfiga@chromium.org, robin.murphy@arm.com,
        jeffy.chen@rock-chips.com, hjc@rock-chips.com,
        enric.balletbo@collabora.co.uk, tomeu.vizoso@collabora.co.uk,
        stable@vger.kernel.org
Subject: Re: [PATCH v4 2/2] drm/rockchip: vop: fix irq disabled after vop driver probed
Date: Mon, 18 Jun 2018 10:19:46 +0200
Message-ID: <1637509.0BUGQyR5Xn@diego>
In-Reply-To: <edc71874-4517-c097-c851-d60565f06817@arm.com>
References: <20180612132028.27490-1-heiko@sntech.de> <20180612132028.27490-3-heiko@sntech.de> <edc71874-4517-c097-c851-d60565f06817@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hi Marc,

Am Mittwoch, 13. Juni 2018, 15:01:27 CEST schrieb Marc Zyngier:
> On 12/06/18 14:20, Heiko Stuebner wrote:
> > From: Sandy Huang <hjc@rock-chips.com>
> > 
> > The vop irq is shared between vop and iommu and irq probing in the
> > iommu driver moved to the probe function recently. This can in some
> > cases lead to a stall if the irq is triggered while the vop driver
> > still has it disabled, but the vop irq handler gets called.
> > 
> > But there is no real need to disable the irq, as the vop can simply
> > also track its enabled state and ignore irqs in that case.
> > For this we can simply check the power-domain state of the vop,
> > similar to how the iommu driver does it.
> > 
> > So remove the enable/disable handling and add appropriate condition
> > to the irq handler.
> > 
> > changes in v2:
> > - move to just check the power-domain state
> > - add clock handling
> > changes in v3:
> > - clarify comment to speak of runtime-pm not power-domain
> > changes in v4:
> > - address Marc's comments (clk-enable WARN_ON and style improvement)
> > 
> > Fixes: d0b912bd4c23 ("iommu/rockchip: Request irqs in rk_iommu_probe()")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > Tested-by: Ezequiel Garcia <ezequiel@collabora.com>
> 
> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>

could I ask you to also look at patch1 of this series, to give it an
Ack or Review? drm-misc documentation very strongly suggests [0]
to have at least another set of eyes on a patch and so far noone
came forward ;-)

This of course also applies to everybody else in the Cc list :-D .


Thanks
Heiko


[0] https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html#merge-criteria