* [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request
@ 2024-05-16 16:05 Souradeep Chakrabarti
2024-05-16 16:47 ` Dexuan Cui
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Souradeep Chakrabarti @ 2024-05-16 16:05 UTC (permalink / raw)
To: kys, haiyangz, wei.liu, decui, davem, edumazet, kuba, pabeni,
longli, yury.norov, leon, cai.huoqing, ssengar, vkuznets, tglx,
linux-hyperv, netdev, linux-kernel, linux-rdma
Cc: schakrabarti, Souradeep Chakrabarti, stable
Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
This patch fixes that.
Cc: stable@vger.kernel.org
Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
---
drivers/net/ethernet/microsoft/mana/hw_channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
index 2729a2c5acf9..ca814fe8a775 100644
--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
+++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
@@ -848,7 +848,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
}
if (!wait_for_completion_timeout(&ctx->comp_event,
- (msecs_to_jiffies(hwc->hwc_timeout) * HZ))) {
+ (msecs_to_jiffies(hwc->hwc_timeout)))) {
dev_err(hwc->dev, "HWC: Request timed out!\n");
err = -ETIMEDOUT;
goto out;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request
2024-05-16 16:05 [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request Souradeep Chakrabarti
@ 2024-05-16 16:47 ` Dexuan Cui
2024-05-16 16:54 ` Brett Creeley
2024-05-16 17:18 ` Andrew Lunn
2 siblings, 0 replies; 4+ messages in thread
From: Dexuan Cui @ 2024-05-16 16:47 UTC (permalink / raw)
To: Souradeep Chakrabarti, KY Srinivasan, Haiyang Zhang,
wei.liu@kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, Long Li, yury.norov@gmail.com,
leon@kernel.org, cai.huoqing@linux.dev,
ssengar@linux.microsoft.com, vkuznets, tglx@linutronix.de,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Cc: Souradeep Chakrabarti, stable@vger.kernel.org
> From: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> Sent: Thursday, May 16, 2024 9:06 AM
> ...
> Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
> This patch fixes that.
>
> Cc: stable@vger.kernel.org
> Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
> Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> ---
Looks good to me.
Reviewed-by: Dexuan Cui <decui@microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request
2024-05-16 16:05 [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request Souradeep Chakrabarti
2024-05-16 16:47 ` Dexuan Cui
@ 2024-05-16 16:54 ` Brett Creeley
2024-05-16 17:18 ` Andrew Lunn
2 siblings, 0 replies; 4+ messages in thread
From: Brett Creeley @ 2024-05-16 16:54 UTC (permalink / raw)
To: Souradeep Chakrabarti, kys, haiyangz, wei.liu, decui, davem,
edumazet, kuba, pabeni, longli, yury.norov, leon, cai.huoqing,
ssengar, vkuznets, tglx, linux-hyperv, netdev, linux-kernel,
linux-rdma
Cc: schakrabarti, stable
On 5/16/2024 9:05 AM, Souradeep Chakrabarti wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
> This patch fixes that.
>
> Cc: stable@vger.kernel.org
> Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
> Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> ---
> drivers/net/ethernet/microsoft/mana/hw_channel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
LGTM.
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request
2024-05-16 16:05 [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request Souradeep Chakrabarti
2024-05-16 16:47 ` Dexuan Cui
2024-05-16 16:54 ` Brett Creeley
@ 2024-05-16 17:18 ` Andrew Lunn
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2024-05-16 17:18 UTC (permalink / raw)
To: Souradeep Chakrabarti
Cc: kys, haiyangz, wei.liu, decui, davem, edumazet, kuba, pabeni,
longli, yury.norov, leon, cai.huoqing, ssengar, vkuznets, tglx,
linux-hyperv, netdev, linux-kernel, linux-rdma, schakrabarti,
stable
On Thu, May 16, 2024 at 09:05:38AM -0700, Souradeep Chakrabarti wrote:
> Commit 62c1bff593b7 added an extra HZ along with msecs_to_jiffies.
> This patch fixes that.
>
> Cc: stable@vger.kernel.org
> Fixes: 62c1bff593b7 ("net: mana: Configure hwc timeout from hardware")
> Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq
Please set the Subject line to [PATCH net] to indicate which tree this
applies to.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-16 17:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 16:05 [PATCH] net: mana: Fix the extra HZ in mana_hwc_send_request Souradeep Chakrabarti
2024-05-16 16:47 ` Dexuan Cui
2024-05-16 16:54 ` Brett Creeley
2024-05-16 17:18 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox