* [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT
@ 2024-12-04 5:36 Shradha Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Shradha Gupta @ 2024-12-04 5:36 UTC (permalink / raw)
Cc: Shradha Gupta, stable
The current requested response version(V1) for MANA_QUERY_GF_STAT query
results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
0 always.
In order to get the correct value for this counter we request the response
version to be V2.
Cc: stable@vger.kernel.org
Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to ethtool")
Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
---
drivers/net/ethernet/microsoft/mana/mana_en.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 57ac732e7707..f73848a4feb3 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2536,6 +2536,7 @@ void mana_query_gf_stats(struct mana_port_context *apc)
mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_GF_STAT,
sizeof(req), sizeof(resp));
+ req.hdr.resp.msg_version = GDMA_MESSAGE_V2;
req.req_stats = STATISTICS_FLAGS_RX_DISCARDS_NO_WQE |
STATISTICS_FLAGS_RX_ERRORS_VPORT_DISABLED |
STATISTICS_FLAGS_HC_RX_BYTES |
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT
@ 2024-12-04 5:48 Shradha Gupta
2024-12-04 18:01 ` Haiyang Zhang
2024-12-05 11:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Shradha Gupta @ 2024-12-04 5:48 UTC (permalink / raw)
To: linux-hyperv, netdev, linux-kernel
Cc: Shradha Gupta, K. Y. Srinivasan, Haiyang Zhang, Wei Liu,
Dexuan Cui, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Long Li, Konstantin Taranov,
Souradeep Chakrabarti, Erick Archer, Shradha Gupta, stable
The current requested response version(V1) for MANA_QUERY_GF_STAT query
results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
0 always.
In order to get the correct value for this counter we request the response
version to be V2.
Cc: stable@vger.kernel.org
Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to ethtool")
Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
---
drivers/net/ethernet/microsoft/mana/mana_en.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 57ac732e7707..f73848a4feb3 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2536,6 +2536,7 @@ void mana_query_gf_stats(struct mana_port_context *apc)
mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_GF_STAT,
sizeof(req), sizeof(resp));
+ req.hdr.resp.msg_version = GDMA_MESSAGE_V2;
req.req_stats = STATISTICS_FLAGS_RX_DISCARDS_NO_WQE |
STATISTICS_FLAGS_RX_ERRORS_VPORT_DISABLED |
STATISTICS_FLAGS_HC_RX_BYTES |
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT
2024-12-04 5:48 [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT Shradha Gupta
@ 2024-12-04 18:01 ` Haiyang Zhang
2024-12-05 11:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: Haiyang Zhang @ 2024-12-04 18:01 UTC (permalink / raw)
To: Shradha Gupta, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: KY Srinivasan, Wei Liu, Dexuan Cui, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Long Li,
Konstantin Taranov, Souradeep Chakrabarti, Erick Archer,
Shradha Gupta, stable@vger.kernel.org
> -----Original Message-----
> From: Shradha Gupta <shradhagupta@linux.microsoft.com>
> Sent: Wednesday, December 4, 2024 12:48 AM
> To: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Shradha Gupta <shradhagupta@linux.microsoft.com>; KY Srinivasan
> <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Wei Liu
> <wei.liu@kernel.org>; Dexuan Cui <decui@microsoft.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; Long Li <longli@microsoft.com>; Konstantin
> Taranov <kotaranov@microsoft.com>; Souradeep Chakrabarti
> <schakrabarti@linux.microsoft.com>; Erick Archer
> <erick.archer@outlook.com>; Shradha Gupta <shradhagupta@microsoft.com>;
> stable@vger.kernel.org
> Subject: [PATCH net] net :mana :Request a V2 response version for
> MANA_QUERY_GF_STAT
>
> The current requested response version(V1) for MANA_QUERY_GF_STAT query
> results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
> 0 always.
> In order to get the correct value for this counter we request the response
> version to be V2.
>
> Cc: stable@vger.kernel.org
> Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to
> ethtool")
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT
2024-12-04 5:48 [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT Shradha Gupta
2024-12-04 18:01 ` Haiyang Zhang
@ 2024-12-05 11:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-05 11:10 UTC (permalink / raw)
To: Shradha Gupta
Cc: linux-hyperv, netdev, linux-kernel, kys, haiyangz, wei.liu, decui,
andrew+netdev, davem, edumazet, kuba, pabeni, longli, kotaranov,
schakrabarti, erick.archer, shradhagupta, stable
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 3 Dec 2024 21:48:20 -0800 you wrote:
> The current requested response version(V1) for MANA_QUERY_GF_STAT query
> results in STATISTICS_FLAGS_TX_ERRORS_GDMA_ERROR value being set to
> 0 always.
> In order to get the correct value for this counter we request the response
> version to be V2.
>
> Cc: stable@vger.kernel.org
> Fixes: e1df5202e879 ("net :mana :Add remaining GDMA stats for MANA to ethtool")
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
>
> [...]
Here is the summary with links:
- [net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT
https://git.kernel.org/netdev/net/c/31f1b55d5d7e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-05 11:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 5:48 [PATCH net] net :mana :Request a V2 response version for MANA_QUERY_GF_STAT Shradha Gupta
2024-12-04 18:01 ` Haiyang Zhang
2024-12-05 11:10 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2024-12-04 5:36 Shradha Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox