Re: [PATCH v2 6.1] net: add netdev_lockdep_set_classes() to virtual drivers

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 0bef512012b1cd8820f0c9ec80e5f8ceb43fdd59

WARNING: Author mismatch between patch and upstream commit:
Backport author: Sumanth Gavini <sumanth.gavini@yahoo.com>
Commit author: Eric Dumazet <edumazet@google.com>

Status in newer kernel trees:
6.15.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Not found

Note: The patch differs from the upstream commit:
---
1:  0bef512012b1 ! 1:  9684eff65270 net: add netdev_lockdep_set_classes() to virtual drivers
    @@
      ## Metadata ##
    -Author: Eric Dumazet <edumazet@google.com>
    +Author: Sumanth Gavini <sumanth.gavini@yahoo.com>
     
      ## Commit message ##
         net: add netdev_lockdep_set_classes() to virtual drivers
     
    +    commit 0bef512012b1cd8820f0c9ec80e5f8ceb43fdd59 upstream.
    +
         Based on a syzbot report, it appears many virtual
         drivers do not yet use netdev_lockdep_set_classes(),
         triggerring lockdep false positives.
    @@ Commit message
         Signed-off-by: Eric Dumazet <edumazet@google.com>
         Link: https://lore.kernel.org/r/20240212140700.2795436-4-edumazet@google.com
         Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    +    Signed-off-by: Sumanth Gavini <sumanth.gavini@yahoo.com>
     
      ## drivers/net/dummy.c ##
     @@ drivers/net/dummy.c: static int dummy_dev_init(struct net_device *dev)
    @@ drivers/net/veth.c: static void veth_free_queues(struct net_device *dev)
      ## drivers/net/vxlan/vxlan_core.c ##
     @@ drivers/net/vxlan/vxlan_core.c: static int vxlan_init(struct net_device *dev)
      	if (err)
    - 		goto err_gro_cells_destroy;
    + 		goto err_free_percpu;
      
     +	netdev_lockdep_set_classes(dev);
      	return 0;
      
    - err_gro_cells_destroy:
    + err_free_percpu:
     
      ## net/ipv4/ip_tunnel.c ##
     @@ net/ipv4/ip_tunnel.c: int ip_tunnel_init(struct net_device *dev)
    @@ net/ipv6/ip6_gre.c: static int ip6erspan_tap_init(struct net_device *dev)
     
      ## net/ipv6/ip6_tunnel.c ##
     @@ net/ipv6/ip6_tunnel.c: ip6_tnl_dev_init_gen(struct net_device *dev)
    - 	dev->max_mtu = IP6_MAX_MTU - dev->hard_header_len;
    + 	dev->max_mtu = IP6_MAX_MTU - dev->hard_header_len - t_hlen;
      
      	netdev_hold(dev, &t->dev_tracker, GFP_KERNEL);
     +	netdev_lockdep_set_classes(dev);

---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| origin/linux-6.1.y        | Success     | Success    |