Re: [PATCH 5.10.y] comedi: pcl812: Fix bit shift out of bounds

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: b14b076ce593f72585412fc7fd3747e03a5e3632

Status in newer kernel trees:
6.15.y | Not found
6.12.y | Not found
6.6.y | Not found
6.1.y | Not found
5.15.y | Not found

Note: The patch differs from the upstream commit:
---
1:  b14b076ce593 ! 1:  08dbf07f845c comedi: pcl812: Fix bit shift out of bounds
    @@ Metadata
      ## Commit message ##
         comedi: pcl812: Fix bit shift out of bounds
     
    +    [ Upstream commit b14b076ce593f72585412fc7fd3747e03a5e3632 ]
    +
         When checking for a supported IRQ number, the following test is used:
     
                 if ((1 << it->options[1]) & board->irq_bits) {
    @@ Commit message
         Link: https://lore.kernel.org/r/20250707133429.73202-1-abbotti@mev.co.uk
         Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
     
    - ## drivers/comedi/drivers/pcl812.c ##
    -@@ drivers/comedi/drivers/pcl812.c: static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    - 		if (IS_ERR(dev->pacer))
    - 			return PTR_ERR(dev->pacer);
    + ## drivers/staging/comedi/drivers/pcl812.c ##
    +@@ drivers/staging/comedi/drivers/pcl812.c: static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
    + 		if (!dev->pacer)
    + 			return -ENOMEM;
      
     -		if ((1 << it->options[1]) & board->irq_bits) {
     +		if (it->options[1] > 0 && it->options[1] < 16 &&

---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| origin/linux-5.10.y       | Success     | Success    |