From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10.y] comedi: pcl812: Fix bit shift out of bounds
Date: Fri, 25 Jul 2025 19:24:24 -0400 [thread overview]
Message-ID: <1753470120-8a5225b9@stable.kernel.org> (raw)
In-Reply-To: <20250724181257.291722-4-abbotti@mev.co.uk>
[ Sasha's backport helper bot ]
Hi,
✅ All tests passed successfully. No issues detected.
No action required from the submitter.
The upstream commit SHA1 provided is correct: b14b076ce593f72585412fc7fd3747e03a5e3632
Status in newer kernel trees:
6.15.y | Not found
6.12.y | Not found
6.6.y | Not found
6.1.y | Not found
5.15.y | Not found
Note: The patch differs from the upstream commit:
---
1: b14b076ce593 ! 1: b9004585cda3 comedi: pcl812: Fix bit shift out of bounds
@@ Metadata
## Commit message ##
comedi: pcl812: Fix bit shift out of bounds
+ [ Upstream commit b14b076ce593f72585412fc7fd3747e03a5e3632 ]
+
When checking for a supported IRQ number, the following test is used:
if ((1 << it->options[1]) & board->irq_bits) {
@@ Commit message
Link: https://lore.kernel.org/r/20250707133429.73202-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
- ## drivers/comedi/drivers/pcl812.c ##
-@@ drivers/comedi/drivers/pcl812.c: static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
- if (IS_ERR(dev->pacer))
- return PTR_ERR(dev->pacer);
+ ## drivers/staging/comedi/drivers/pcl812.c ##
+@@ drivers/staging/comedi/drivers/pcl812.c: static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
+ if (!dev->pacer)
+ return -ENOMEM;
- if ((1 << it->options[1]) & board->irq_bits) {
+ if (it->options[1] > 0 && it->options[1] < 16 &&
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| origin/linux-5.10.y | Success | Success |
next prev parent reply other threads:[~2025-07-25 23:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 18:12 [PATCH 5.10.y] comedi: Fail COMEDI_INSNLIST ioctl if n_insns is too large Ian Abbott
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: Fix some signed shift left operations Ian Abbott
2025-07-25 23:24 ` Sasha Levin
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: das16m1: Fix bit shift out of bounds Ian Abbott
2025-07-25 23:24 ` Sasha Levin
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: pcl812: " Ian Abbott
2025-07-25 23:24 ` Sasha Levin [this message]
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: aio_iiro_16: " Ian Abbott
2025-07-25 23:26 ` Sasha Levin
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: das6402: " Ian Abbott
2025-07-25 23:24 ` Sasha Levin
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: Fix use of uninitialized data in insn_rw_emulate_bits() Ian Abbott
2025-07-25 23:24 ` Sasha Levin
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: Fix initialization of data for instructions that write to subdevice Ian Abbott
2025-07-26 0:24 ` Sasha Levin
2025-07-24 18:12 ` [PATCH 5.10.y] comedi: comedi_test: Fix possible deletion of uninitialized timers Ian Abbott
2025-07-26 1:01 ` Sasha Levin
2025-07-26 1:01 ` [PATCH 5.10.y] comedi: Fail COMEDI_INSNLIST ioctl if n_insns is too large Sasha Levin
-- strict thread matches above, loose matches on Subject: below --
2025-07-24 18:16 [PATCH 5.10.y] comedi: pcl812: Fix bit shift out of bounds Ian Abbott
2025-07-26 1:01 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1753470120-8a5225b9@stable.kernel.org \
--to=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox